973332 - Add "leave-open" keyword support to mcMerge

Status: RESOLVED FIXED

(Tree Management :: Bugherder, defect)

Comment 1

[Graeme McCutcheon [:graememcc]]

Attachment: Patch

Comment 2

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 8376823 [details] [diff] [review]
Patch

LGTM from what I can tell, but I'd prefer if Ed took a look at this too as someone's who a bit more competent at this :)

Comment 3

[Ed Morley [:emorley]]

Comment on attachment 8376823 [details] [diff] [review]
Patch

Looks good and works locally at least for the whiteboard behaviour still. Thank you for doing this :-)

Comment 4

[Graeme McCutcheon [:graememcc]]

https://hg.mozilla.org/webtools/tbpl/rev/e34157f10528

Comment 5

[Ed Morley [:emorley]]

In production :-)

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Looks like it's working well. I just merged a bug with the keyword set and mcMerge is properly handling it. Can we send a note to dev-platform making mention of this change?

Comment 7

[Ryan VanderMeulen [:RyanVM]]

This is fodder for a new bug, but we may want some visible indication in the UI that leave-open is set on the bug. We sorta had that before because the whiteboard is visible, but we don't see what keywords are set.

Comment 8

[Graeme McCutcheon [:graememcc]]

(In reply to Ryan VanderMeulen [:RyanVM UTC-5] from comment #6)
> Can we send a note to dev-platform making mention of this change?
Done. Currently held in moderation, should show up eventually.

(In reply to Ryan VanderMeulen [:RyanVM UTC-5] from comment #7)
> This is fodder for a new bug, but we may want some visible indication in the
> UI that leave-open is set on the bug.
Ah, good point. Bug 974838.