967197 - "Create Account" and "Sign In" links in Sync preferences should go to separate pages

Status: VERIFIED FIXED

(Firefox :: Sync, defect)

Description

[:Gavin Sharp [email: [e-mail]]]

Right now both links call gSyncPane.signIn(), which just open about:accounts?action=signin. The "create account" link should go directly to an account creation page rather than the "sign in" page.

This probably depends on the web side/about:accounts supporting an "action" parameter for "createaccount".

Comment 1

[Mark Hammond [:markh] [:mhammond]]

Zack,
  We can have about:accounts handle this case fairly easy, but it will still need to tell the remote iframe to do the right thing.  Who is the best person to help with that, and should that be tracked in a different bug?

Comment 3

[:Gavin Sharp [email: [e-mail]]]

Edwin filed https://github.com/mozilla/fxa-content-server/issues/501 on the content server.

Comment 4

[Zachary Carter [:zaach]]

The content-server lets you link directly to the sign in page, e.g. https://accounts.firefox.com/signin, so we could have about:accounts load that page when the action=signin.

Comment 5

[Tim Taubert [:ttaubert] (inactive)]

Attachment: 0001-Bug-967197-Create-Account-and-Sign-In-links-in-Sync-.patch

Comment 6

[Tim Taubert [:ttaubert] (inactive)]

The attached patch works fine, however we're being redirected to /signup after the server receives our answer to its "session_status" command. Zack, can we not do this for the /signin page?

Comment 7

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/integration/fx-team/rev/27959c18c6d2

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/27959c18c6d2

Comment 9

[:Gavin Sharp [email: [e-mail]]]

(In reply to Tim Taubert [:ttaubert] from comment #6)
> The attached patch works fine, however we're being redirected to /signup
> after the server receives our answer to its "session_status" command. Zack,
> can we not do this for the /signin page?

File a Mozilla Services::Server: Firefox Accounts bug and hang it off bug 969626?

Comment 10

[Zachary Carter [:zaach]]

(In reply to Tim Taubert [:ttaubert] from comment #6)
> The attached patch works fine, however we're being redirected to /signup
> after the server receives our answer to its "session_status" command. Zack,
> can we not do this for the /signin page?

I fix for this will be on the staging servers shortly, and pushed to production next week. You can try it out now on the "latest" server: https://accounts-latest.dev.lcip.org.

Comment 11

[Edwin Wong [:edwong]]

this fix should deploy to prod on 2/25

Comment 12

[Mark Hammond [:markh] [:mhammond]]

Comment on attachment 8377490 [details] [diff] [review]
0001-Bug-967197-Create-Account-and-Sign-In-links-in-Sync-.patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): FxA sync
User impact if declined: User clicking "Sign in" in sync preferences will be taken to a "create account" page.
Testing completed (on m-c, etc.): Landed on m-c 
Risk to taking this patch (and alternatives if risky): Low
String or IDL/UUID changes made by this patch: None

Comment 13

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/7cfcea73b7e9