967333 - Sync does not immediately acknowledge verification even after "Verified" link is opened

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Android Sync, defect, P1)

Description

[Chenxia Liu [:liuche]]

STR:
1. Open Settings > Sync for the first time, create an account.
2. Receive verification email and click on link.
3. See "Verified" page (with non-channel-specific favicon and logo).
4. Open Settings > Sync.

Expected:
Sync is set up

Actual:
Sync checkboxes are greyed out and says the email account needs to be verified. Tapping on the screen sends another confirmation email and displays the "Email sent" screen.

Comment 1

[Richard Newman [:rnewman]]

This is current expected behavior. We won't know you're verified until the next time we try to sync.

We intend to check more aggressively -- make those screens 'live' -- but that's a balancing act between screwing your phone battery/network/the server, and lagging behind reality.

Comment 2

[Nick Alexander :nalexander [he/him]]

Attachment: github PR

Following Bug 966104, there's not much to be done here short of polling.  This is strictly best effort; see the commit comment in the PR.

Comment 3

[Richard Newman [:rnewman]]

Comment on attachment 8385013 [details] [review]
github PR

I worry about this causing races with newly set up clients. If we had more time, I'd be inclined to have a "tentative" syncing mode, where if we're not the first client we only sync if there's data on the server, or we only fetch a token but never actually sync.

File a follow-up, perhaps?

Comment 4

[Nick Alexander :nalexander [he/him]]

https://hg.mozilla.org/integration/fx-team/rev/a9dbe97ba404

Comment 5

[Nick Alexander :nalexander [he/him]]

This is tracking-fennec29+, but ended up depending on the fixes in Bug 966104, which is tracking-fennec30+.  Requesting uplift to Beta (29) for both.

Comment 6

[Nick Alexander :nalexander [he/him]]

Attachment: a9dbe97ba404

[Approval Request Comment]
Bug caused by (feature/regressing bug #): initial FxA landing.

User impact if declined: slightly worse initial Sync set-up experience: we won't transition as quickly or smoothly to "your sync is all ready to go" when possible.

Testing completed (on m-c, etc.): tested locally.  This is really small, just asks for a sync on activity start and stop.

Risk to taking this patch (and alternatives if risky): none.

String or IDL/UUID changes made by this patch: none.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/a9dbe97ba404

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Depends on bug 966104.

Comment 9

[Nick Alexander :nalexander [he/him]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/84931e0fd466