966104 - Add statusChangeListener to FxA status screen

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Android Sync, defect, P2)

Description

[Richard Newman [:rnewman]]

http://stackoverflow.com/a/6253713/22003

We'll be told when a sync occurs (which we can show), and we'll know when it finishes (so we can find out what new state we're in).

Comment 1

[Nick Alexander :nalexander [he/him]]

Attachment: github PR

Comment 3

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8385009 [details] [review]
github PR

I reworked the PR quite a bit, so asking for a quick once over.

Comment 4

[Nick Alexander :nalexander [he/him]]

https://hg.mozilla.org/integration/fx-team/rev/06d867c27d14

Comment 5

[Nick Alexander :nalexander [he/him]]

sigh:

https://hg.mozilla.org/integration/fx-team/rev/8dadefdc975c

Comment 6

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/06d867c27d14
https://hg.mozilla.org/mozilla-central/rev/8dadefdc975c

Comment 7

[Nick Alexander :nalexander [he/him]]

This is tracking-fennec30+, but ended up being a pre-req for a tracking-fennec29+ ticket.  Requesting uplift for both.

Comment 8

[Nick Alexander :nalexander [he/him]]

Attachment: 06d867c27d14

[Approval Request Comment]
Bug caused by (feature/regressing bug #): initial FxA landing.

User impact if declined: "static" Sync Status screen.  In practice, this will manifest itself as greyed-out "What to Sync" boxes immediately after signing-in to Sync.  This will at least get those greyed-out boxes to enable when the first sync complete.

Testing completed (on m-c, etc.): it's been baking for a few days on m-c.

Risk to taking this patch (and alternatives if risky): low.  We're adding new things here.

String or IDL/UUID changes made by this patch: none.

I just checked and this might not apply cleanly on mozilla-beta: there are problems because of my bad landing, but they're easy to work around; but there may be pre-reqs that require work to avoid.  I could go either way: we can cut risk by uplifting to mozilla-aurora, or be a little more aggressive and push to mozilla-beta.

Comment 9

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8404908 [details] [diff] [review]
06d867c27d14

Nick, is it really an issue not to have this feature in 29? The patch is pretty big. Anyway, approving for aurora
By the way, I am not sure why you don't propose a patch for mozilla-beta which applies cleanly?

Comment 10

[Nick Alexander :nalexander [he/him]]

(In reply to Sylvestre Ledru [:sylvestre] from comment #9)
> Comment on attachment 8404908 [details] [diff] [review]
> 06d867c27d14
> 
> Nick, is it really an issue not to have this feature in 29? The patch is
> pretty big. Anyway, approving for aurora

Nope, it's not; and I agree with your call.

> By the way, I am not sure why you don't propose a patch for mozilla-beta
> which applies cleanly?

In general, I only ask to uplift things that apply cleanly with |hg graft|.  Because of the amount of FxA uplifts, that's been hard to maintain.  You're correct that it's on me to prepare the patch before asking for uplift.  Next time!

Comment 11

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8404908 [details] [diff] [review]
06d867c27d14

Removing the beta request since this has non-trivial dependencies and is a little large for this late in the game.

Comment 12

[Nick Alexander :nalexander [he/him]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/ce9a983cdfba