967674 - Port new Fxa sync options work to in-content prefs

Status: VERIFIED FIXED

(Firefox :: Sync, defect)

Description

[Tim Nguyen :ntim]

When I finish setting up my Firefox account then go to about:accounts, it provides me a "Manage" link, that link makes me go to the options. In the options, there is a link called "Set up Firefox Sync" that makes me go to "about:accounts". So basically, setting up Firefox sync makes me go back and forth those pages. There's also a reconnect to sync button in the menu panel even if I finished setting up my FFX account.

I'll try restarting Firefox, see if this still happens.

Comment 1

[Tim Nguyen :ntim]

Still happens after restart

Comment 2

[u428464]

Do you use in-content prefs ?

Comment 3

[Tim Nguyen :ntim]

(In reply to Guillaume C. [:ge3k0s] from comment #2)
> Do you use in-content prefs ?

Yep

Comment 4

[Tim Nguyen :ntim]

Doesn't happen with in content prefs disabled.

Comment 5

[u428464]

So yeah I encountered the same issue. It's because the Sync pane hasn't been ported to in-content prefs yet.

Comment 8

[u428464]

Since bug 738796 is gonna land soon. I think this bug should have an highest priority.

Comment 9

[:Gijs (out for now; he/him)]

(In reply to Guillaume C. [:ge3k0s] from comment #8)
> Since bug 738796 is gonna land soon. I think this bug should have an highest
> priority.

That bug won't make in-content prefs the default yet.

Comment 10

[u428464]

(In reply to :Gijs Kruitbosch (no internet 29 Mar - 6 Apr) from comment #9)
> (In reply to Guillaume C. [:ge3k0s] from comment #8)
> > Since bug 738796 is gonna land soon. I think this bug should have an highest
> > priority.
> 
> That bug won't make in-content prefs the default yet.

I know there is still a bunch of priority to land in-content prefs, but in fact this bug is one of them. ;)

Comment 11

[Richard Marti (:Paenglab)]

Attachment: inContentNewSynch.patch

This patch updates the inContent synch files to the actual prefWindow files.

Comment 12

[Mark Hammond [:markh] [:mhammond]]

Comment on attachment 8398915 [details] [diff] [review]
inContentNewSynch.patch

Review of attachment 8398915 [details] [diff] [review]:
-----------------------------------------------------------------

looks good, thanks.

Comment 13

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/fx-team/rev/91494766ce39

Comment 15

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/91494766ce39

Comment 16

[Liz Henry (:lizzard) (relman/hg->git project)]

Tracy, are you the right person to verify for Sync issues or do you want to pass this on to Florin and  his team?  Thanks!

Comment 17

[Tracy Walker [:tracy]]

lizzard,  yes, assign me as QA contact for any client side Sync bugs. Thanks.


verified this one is fixed on 31.  It will need uplift to 29 and 30.

Comment 18

[:Gijs (out for now; he/him)]

(In reply to [:tracy] Tracy Walker - QA Mentor from comment #17)
> It will need uplift to 29 and 30.

Indeed. Richard or Mark, can either of you make the required uplift requests if you're comfortable with the patch going to 29/30 ? Thanks!

Comment 19

[Mark Hammond [:markh] [:mhammond]]

Comment on attachment 8398915 [details] [diff] [review]
inContentNewSynch.patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): FxA sync
User impact if declined: In-content prefs will not support FxA sync
Testing completed (on m-c, etc.): On m-c
Risk to taking this patch (and alternatives if risky): Low
String or IDL/UUID changes made by this patch: None

Comment 20

[Marco Mucci [:MarcoM]]

Hi Tracy, will verification of this bug be able to be completed before the end of our iteration on Monday April 14?

Comment 21

[Tracy Walker [:tracy]]

Marco, this has already been verified on Nightly (Fx31).  Also, I'll be on the lookout for the uplifts to  verify on each branch as the landings occur. With next available build, that is. :-)

Comment 22

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/24669347a557
https://hg.mozilla.org/releases/mozilla-beta/rev/c8bcfc32f855