967785 - need TBD image for logged-out panel (and also FTE start panel)

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Attachment: Screenshot 2014-02-04 12.52.11.png

another one for jgruen. we definitely need something here, the grey square isn't quite right ;-)

Comment 1

[John Gruen [:jgruen]]

This should just be the Firefox Logo. Do you need an asset for this?

Comment 2

[John Gruen [:jgruen]]

Flat Fox:

https://www.dropbox.com/s/zwuk9bl74i46mog/Flat%20Fox%402x.png
https://www.dropbox.com/s/ov087dvunxg1u8g/Flat%20Fox.png

LMK if we need different sizes or colors

Comment 3

[John Gruen [:jgruen]]

foxes in here: https://www.dropbox.com/sh/falu4kt9w22cy4r/My_T8XvxYi

Comment 4

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Attachment: Github PR 18608

Hi reviewers,

Do you have time for a quick review?

This is a very simple fix (replacing a TBD image with a final image), but it spans three apps. Trying to minimize paperwork by putting all three changes in one PR.

Thanks very much!

Jared

Comment 5

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

I should also add that I've separated the three commits that touch each of the separate apps, to make reviewing simpler for each of you.

Thanks again :-)

Comment 7

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Two more things:

1. To make it clear how things were changing, I've added before and after screenshots of each of the affected screens as comments in the github pull request.

2. I also needed to update an envelope icon in the settings and system apps. I've added those commits to the existing PR, along with before/after screenshots for those changes, too.

Comment 8

[Fernando Jiménez Moreno [:ferjm]]

Comment on attachment 8411284 [details] [review]
Github PR 18608

Please, run the images through the png_recompress.sh script.

https://github.com/mozilla-b2g/gaia/blob/master/tools/png_recompress.sh

Comment 9

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8411284 [details] [review]
Github PR 18608

r+ for the FTU, once you run the script for compressing the images as Fernando comments.

Thanks!

Comment 10

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

(In reply to Fernando Jiménez Moreno [:ferjm] from comment #8)
> Comment on attachment 8411284 [details] [review]
> Github PR 18608
> 
> Please, run the images through the png_recompress.sh script.
> 
> https://github.com/mozilla-b2g/gaia/blob/master/tools/png_recompress.sh

Thanks! I didn't realize that was even a thing.

Comment 11

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

(In reply to Francisco Jordano [:arcturus] from comment #9)
> Comment on attachment 8411284 [details] [review]
> Github PR 18608
> 
> r+ for the FTU, once you run the script for compressing the images as
> Fernando comments.
> 
> Thanks!

Awesome! Thanks Francisco.

Comment 12

[Fernando Jiménez Moreno [:ferjm]]

Comment on attachment 8411284 [details] [review]
Github PR 18608

Thanks Jared!

Comment 13

[Arthur Chen [:arthurcc][inactive after 6/30]]

Attachment: confirm email.png

Jared, could you request a ui review ensuring this is as expected? And please also flag the owner of the system app for review. Thanks.

Comment 14

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Attachment: Unverified settings panel as seen on hamachi

Hi Arthur - That's odd, are you using the emulator to generate that screenshot? I included a lot of screenshots in the github PR, the hamachi looked fine there[1]. I also reflashed my hamachi with today's master, and the screen looks correct for me still (see this attachment).

What build of gaia/gecko are you using on your device/emulator?

Fernando is a system peer and has given r+, I think we're good there?

[1] https://github.com/mozilla-b2g/gaia/pull/18608#issuecomment-41235020

Comment 15

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8411284 [details] [review]
Github PR 18608

Oh, I guess I tweaked the class name to see all the pages. My screenshot seems wrong as it does not have the email address and which leads to the incorrect layout. r=me, thanks for the patch!

Comment 16

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Master: https://github.com/mozilla-b2g/gaia/commit/6dd01812793ceff82f80e8bee5074e81cea4162d