967829 - overlay not toggled during panel state transitions

Status: RESOLVED DUPLICATE of bug 949051

(Firefox OS Graveyard :: Gaia, defect)

Description

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

isn't there some kind of shared overlay we could use, instead of adding a crufty additional one? or at least reuse the panel from the fxa text app/fxa system app?

Comment 1

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

specifically: when we click, eg, the logout button, an overlay with a spinner should momentarily appear, so that the settings app doesn't jump from screen to screen. this overlay should also appear if the gecko layer detects a change, for example, when the user verifies their email and the client is updated, we want to see unverified panel -> overlay -> verified panel.

technically this is just polish, but the code's in the current branch and is busted, so, we should just fix it or switch to using some shared component.

Comment 2

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

lol, I appear to just have found the bug here, when the firefox_accounts.html section is appended to the page, the id is set to the section name, so it's id="fxa", not id="fxa-container".

this should be fixed as part of the refactored settings app mega-PR, but leaving this open to ensure I double-check it's fixed after that PR lands

Comment 3

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

As ferjm pointed out[1], stuff fixed as part of a larger patch should be closed as a dup of that patch.

So, closing as dup of 949051

[1] https://bugzilla.mozilla.org/show_bug.cgi?id=941723#c5