Status

defect
RESOLVED WONTFIX
6 years ago
9 months ago

People

(Reporter: toxborrow, Unassigned)

Tracking

Details

(Whiteboard: [qa-] [dependency: marketplace])

(Reporter)

Description

6 years ago
The goal of this release is that on the device by signing into WheresMyFox or Marketplace, you're signed into both. This is really SSO on the device. 

Additional Information:
FxA Wiki: https://wiki.mozilla.org/Identity/FirefoxAccounts
FxA Roadmap: https://wiki.mozilla.org/Identity/Roadmap
(Reporter)

Comment 1

6 years ago
Since we have an existing meta bug [920135], I am going to link that bug here.  Moving forward we will be using this program and project tree for FxA on FxOS tracking.
Summary: [project] FxA on FxOS (v1.4) → [project] FxA on FxOS
(Reporter)

Updated

6 years ago
Whiteboard: [qa-]

Updated

5 years ago
Depends on: 949055

Updated

5 years ago
Depends on: 949053

Updated

5 years ago
Depends on: 949051

Updated

5 years ago
Depends on: 949049

Updated

5 years ago
Depends on: 949052

Updated

5 years ago
Depends on: 949063

Updated

5 years ago
Depends on: 949065

Updated

5 years ago
Depends on: 949069

Updated

5 years ago
Depends on: 949093

Updated

5 years ago
Depends on: 949095

Updated

5 years ago
Depends on: 949097

Updated

5 years ago
Depends on: 949098

Updated

5 years ago
Depends on: 949100

Updated

5 years ago
Depends on: 949102
(Reporter)

Updated

5 years ago
Blocks: 941078
No longer blocks: fxos-accounts
No longer depends on: 941078

Updated

5 years ago
Depends on: 955951

Updated

5 years ago
Depends on: 955952

Updated

5 years ago
Depends on: 960130

Updated

5 years ago
Depends on: 961009

Updated

5 years ago
Depends on: 965492

Updated

5 years ago
Depends on: 965494
Depends on: 897600

Updated

5 years ago
Depends on: 936560

Updated

5 years ago
No longer depends on: 971173

Updated

5 years ago
No longer depends on: 969892
Depends on: 941079

Updated

5 years ago
Depends on: 974096

Updated

5 years ago
No longer depends on: 967508

Updated

5 years ago
No longer depends on: 963859

Updated

5 years ago
No longer depends on: 964417

Updated

5 years ago
Depends on: 974121

Comment 2

5 years ago
Here is the current state of the blockers.
  Gecko:
    About 5 patches with more than 1/2 day of work left, plus 4 waiting review.
  Gaia:
    Two major UI patches, one waiting for a separate issue before r+, the other due to be revised by a Gaia peer Thursday CEST.
    About 5 bugs representing more than 1/2 day of work.

   955951: Gecko blockers
     unassigned:
       971379: Allow certified and privileged apps to call mozID API outside an event handler

     r+:
       955953: FxAccountsClient should set Accept-Language header on all server calls
     r?:
       972582: jwcrypto: base64UrlEncoding/Decoding can alter assertion audience
       945278: Notify about 'getAssertion' errors
       963835: clients need to handle for incorrect case email strings
       969892: Some fixes to the test suite in bug 943521

     patch uploaded:
       945363: Provide SSO sign-out for FXA
       945449: FxAccountsClient should support auth server's backoff protocol
       947374: Certified and packaged apps should be able to declare assertion audience

     assigned:
       967008: getAccounts should return the account info right away even if the account isn't verified
       967508: Write mochitests for services/fxaccounts

     ETA 28 Feb (assigned external):
       968567: Expose the NSS implementation of PBKDF2 HMAC SHA256 from bug 974162 to chrome JS for use by FxAccounts
       971173: FxAccounts.jsm: fetchAndUnwrapKeys cannot be rejected
           972070: FxAccounts.jsm doesn't drop all state when a new user logs in

   955952: Gaia blockers
     unassigned:
       955945: Implement age verification screens for FxA Signup
       964417: Firefox Accounts system app should check state before starting flow
       972645: Implement Reset Password Link or Screen for FxA
       974185: Implement Cancel Account Verification screen or edit language on existing Settings Logout screen 

     f+:
       949051: Sign up for Firefox Accounts in Settings

     patch uploaded:
       897600: Sign In To Firefox on First Run

     assigned:
       974108: Race condition in FxAccountsIACHelper
       963859: Firefox Accounts system app error overlay is blank
       967779: replace persona icon with flat fox icon
       967783: need envelope icon for verified panel
       967785: need TBD image for logged-out panel (and also FTE start panel)
       967787: use l10n.localize helper properly
       967821: menu item - visual/copy bugs
       967829: overlay not toggled during panel state transitions
       967888: panels - visual/copy bugs
       967988: when WMF icon is ready, add WMF and Marketplace icons to logged-in panel

Updated

5 years ago
Depends on: 974999

Updated

5 years ago
No longer depends on: 974990

Comment 3

5 years ago
Here is the current state of the blockers. Lots of progress in last 24 hours. I'm reversing the category listings so least-ready issues come first. We're down to 11 Gecko bugs assigned to us, of which I have marked one with a * to denote potential risk. We're down to 12 Gaia issues (plus 4 "need icon/image"), of which I have conservatively marked 5 as potentially risky.

   955951: Gecko blockers
     assigned:
       967008: getAccounts should return the account info right away even if the account isn't verified
       967508: Write mochitests for services/fxaccounts
      *971379: Allow certified and privileged apps to call mozID API outside an event handler
     patch uploaded:
       947374: Certified and packaged apps should be able to declare assertion audience
     f?:
       945363: Provide SSO sign-out for FXA
       945449: FxAccountsClient should support auth server's backoff protocol
     f+:
       974990: RESTRequest should read intl.accept_languages as infrequently as possible
     r?:
       969892: Some fixes to the test suite in bug 943521
     r+:
       945278: Notify about 'getAssertion' errors
       955953: FxAccountsClient should set Accept-Language header on all server calls
       963835: clients need to handle for incorrect case email strings

     ETA 28 Feb (assigned external):
       968567: Expose the NSS implementation of PBKDF2 HMAC SHA256 from bug 974162 to chrome JS for use by FxAccounts
       971173: FxAccounts.jsm: fetchAndUnwrapKeys cannot be rejected
           972070: FxAccounts.jsm doesn't drop all state when a new user logs in

   955952: Gaia blockers
     unassigned:
      *955945: Implement age verification screens for FxA Signup
      *964417: Firefox Accounts system app should check state before starting flow
       972645: Implement Reset Password Link or Screen for FxA
       974185: Implement Cancel Account Verification screen or edit language on existing Settings Logout screen
     assigned:
      *963859: Firefox Accounts system app error overlay is blank
       967779: replace persona icon with flat fox icon
       967783: need envelope icon for verified panel
       967785: need TBD image for logged-out panel (and also FTE start panel)
       967787: use l10n.localize helper properly
       967821: menu item - visual/copy bugs
       967829: overlay not toggled during panel state transitions
       967888: panels - visual/copy bugs
       967988: when WMF icon is ready, add WMF and Marketplace icons to logged-in panel
     f+:
      *897600: Sign In To Firefox on First Run
      *949051: Sign up for Firefox Accounts in Settings
     r?:
       974108: Race condition in FxAccountsIACHelper

Comment 4

5 years ago
4 Gecko issues resolved in last 18 hours. Remaining risk count: 1 Gecko, 5 Gaia.

   955951: Gecko blockers (7 internal, 1 with *risk, 3 assigned to others)
     assigned:
       967008: getAccounts should return the account info right away even if the account isn't verified
       967508: Write mochitests for services/fxaccounts
      *971379: Allow certified and privileged apps to call mozID API outside an event handler
     patch uploaded:
       947374: Certified and packaged apps should be able to declare assertion audience
     f?:
       945363: Provide SSO sign-out for FXA
       945449: FxAccountsClient should support auth server's backoff protocol
     r?:
       969892: Some fixes to the test suite in bug 943521

     ETA 28 Feb (assigned external):
       968567: Expose the NSS implementation of PBKDF2 HMAC SHA256 from bug 974162 to chrome JS for use by FxAccounts
       971173: FxAccounts.jsm: fetchAndUnwrapKeys cannot be rejected
           972070: FxAccounts.jsm doesn't drop all state when a new user logs in

   955952: Gaia blockers (16, 5 with *risk)
     unassigned:
      *955945: Implement age verification screens for FxA Signup
      *964417: Firefox Accounts system app should check state before starting flow
       972645: Implement Reset Password Link or Screen for FxA
       974185: Implement Cancel Account Verification screen or edit language on existing Settings Logout screen
     assigned:
      *963859: Firefox Accounts system app error overlay is blank
       967779: replace persona icon with flat fox icon
       967783: need envelope icon for verified panel
       967785: need TBD image for logged-out panel (and also FTE start panel)
       967787: use l10n.localize helper properly
       967821: menu item - visual/copy bugs
       967829: overlay not toggled during panel state transitions
       967888: panels - visual/copy bugs
       967988: when WMF icon is ready, add WMF and Marketplace icons to logged-in panel
     f+:
      *897600: Sign In To Firefox on First Run
      *949051: Sign up for Firefox Accounts in Settings
     r?:
       974108: Race condition in FxAccountsIACHelper
As mentioned during todays meeting, I think we can move to nice to have:

- bug 967008
- bug 967508
- bug 968567
- bug 964417
- bug 967779
- bug 967783
- bug 967785
- bug 967787
- bug 967821
- bug 967888

Also, normally, if a patch for a bug A is included within bug B's patches, patch A is closed as a dup of B. It seems that some of the listed issues are already solved in the PR associated to bug 949051. Closing this bugs will make the list smaller :).
ferjm: oh really? ok, in that case there are quite a few bugs I can close out. I'll do that now

Comment 7

5 years ago
Remaining risk count: 0 Gecko, 2 Gaia.
   bug 955951: Gecko blockers (5 internal, 0 with *risk, 2 assigned to others)
     assigned:
       bug 971379: Allow certified and privileged apps to call mozID API outside an event handler
     patch uploaded:
       bug 947374: Certified and packaged apps should be able to declare assertion audience
       bug 945363: Provide SSO sign-out for FXA
     f+:
       bug 945449: FxAccountsClient should support auth server's backoff protocol
     r?:
       bug 969892: Some fixes to the test suite in bug 943521

     ETA 28 Feb (assigned markh):
       bug 971173: FxAccounts.jsm: fetchAndUnwrapKeys cannot be rejected
           bug 972070: FxAccounts.jsm doesn't drop all state when a new user logs in

   bug 955952: Gaia blockers (5, 2 with *risk)
     unassigned:
      *bug 955945: Implement age verification screens for FxA Signup
       bug 972645: Implement Reset Password Link or Screen for FxA
       bug 974185: Implement Cancel Account Verification screen or edit language on existing [screen]
     f+:
      *bug 949051: Sign up for Firefox Accounts in Settings
     r?:
       bug 974108: Race condition in FxAccountsIACHelper

Comment 8

5 years ago
Remaining risk count: 0 Gecko, 2 Gaia.
Changes:
  Every Gecko patch is now at least f?
  Gaia UI patches consolidated under 949051, aka "Das Ungeheur"

   bug 955951: Gecko blockers (5 internal, 0 with *risk, 2 assigned to others)
     f?:
       bug 971379: Allow certified and privileged apps to call mozID API outside an event handler
       bug 947374: Certified and packaged apps should be able to declare assertion audience
       bug 945363: Provide SSO sign-out for FXA
     f+:
       bug 945449: FxAccountsClient should support auth server's backoff protocol
     r?:
       bug 969892: Some fixes to the test suite in bug 943521

     ETA 28 Feb (assigned markh):
       bug 971173: FxAccounts.jsm: fetchAndUnwrapKeys cannot be rejected
           bug 972070: FxAccounts.jsm doesn't drop all state when a new user logs in

   bug 955952: Gaia blockers (4, 1 with *risk)
     unassigned:
       bug 972645: Implement Reset Password Link or Screen for FxA
     assigned:
       bug 955945: Implement age verification screens for FxA Signup
     r?:
      *bug 949051: Sign up for Firefox Accounts in Settings
       bug 974108: Race condition in FxAccountsIACHelper
We might also want to add bug 960130 to the list.

Comment 10

5 years ago
Remaining risk count: 0 Gecko, 1 Gaia.
Changes:
  One Gecko patch headed for checkin.
  All but one Gaia patch awaiting review  or feedback.
  (bug 960130 added to "nice to haves"; will get promoted to blocker with next tier.)

   bug 955951: Gecko blockers (5 internal, 0 with *risk, 2 assigned to others)
     f?:
       bug 971379: Allow certified and privileged apps to call mozID API outside an event handler
       bug 947374: Certified and packaged apps should be able to declare assertion audience
       bug 945363: Provide SSO sign-out for FXA
     r?:
       bug 969892: Some fixes to the test suite in bug 943521

     ETA 28 Feb (assigned markh):
       bug 971173: FxAccounts.jsm: fetchAndUnwrapKeys cannot be rejected
           bug 972070: FxAccounts.jsm doesn't drop all state when a new user logs in

   bug 955952: Gaia blockers (4, 1 with *risk)
     assigned:
       bug 955945: Implement age verification screens for FxA Signup
     f?:
       bug 972645: Implement Reset Password Link or Screen for FxA
     r?:
      *bug 949051: Sign up for Firefox Accounts in Settings
       bug 974108: Race condition in FxAccountsIACHelper

Comment 11

5 years ago
One bug cleared, eight left (one risky), movement on several of them.

   bug 955951: Gecko blockers (4 internal, 0 with *risk, 2 assigned to others)
     f?:
       bug 971379: Allow certified and privileged apps to call mozID API outside an event handler
       bug 947374: Certified and packaged apps should be able to declare assertion audience
       bug 945363: Provide SSO sign-out for FXA
     r?:
       bug 969892: Some fixes to the test suite in bug 943521
     ETA 28 Feb (assigned markh):
       bug 971173: FxAccounts.jsm: fetchAndUnwrapKeys cannot be rejected
           bug 972070: FxAccounts.jsm doesn't drop all state when a new user logs in

   bug 955952: Gaia blockers (4, 1 with *risk)
     f?:
       bug 955945: Implement age verification screens for FxA Signup
     f+:
       bug 972645: Implement Reset Password Link or Screen for FxA
     r?:
      *bug 949051: Sign up for Firefox Accounts in Settings
       bug 974108: Race condition in FxAccountsIACHelper

Comment 12

5 years ago
A couple patches advanced, a couple received mixed feedback. Count unchanged at eight open issues in this priority tier.

   bug 955951: Gecko blockers (4 internal, 0 with *risk, 2 assigned to others)
     patch uploaded:
       bug 945363: Provide SSO sign-out for FXA
     f+:
       bug 947374: Certified and packaged apps should be able to declare assertion audience
       bug 971379: Allow certified and privileged apps to call mozID API outside an event handler
     r?:
       bug 969892: Some fixes to the test suite in bug 943521

     ETA 28 Feb (assigned markh):
       bug 971173: FxAccounts.jsm: fetchAndUnwrapKeys cannot be rejected
           bug 972070: FxAccounts.jsm doesn't drop all state when a new user logs in

   bug 955952: Gaia blockers (4, 1 with *risk)
     patch uploaded:
       bug 972645: Implement Reset Password Link or Screen for FxA
     f?:
       bug 955945: Implement age verification screens for FxA Signup
     r?:
      *bug 949051: Sign up for Firefox Accounts in Settings
       bug 974108: Race condition in FxAccountsIACHelper

Comment 13

5 years ago
Radio silence on Settings. Just asked a very busy DOM peer for review on two bugs, so between his availability and the likelihood of his finding issues, listing those as likely to slip past Thursday.

At risk for Thu March 6 (NOT necessarily at risk for Code Freeze Mar 18):
  Gaia (need Settings peer review):
      *bug 949051: Sign up for Firefox Accounts in Settings
       bug 974108: Race condition in FxAccountsIACHelper
  Gecko (need DOM peer review):
       bug 947374: Certified and packaged apps should be able to declare assertion audience
       bug 971379: Allow certified and privileged apps to call mozID API outside an event handler

On track for r+ by Thu March 6:
   Gecko
       bug 945363: Provide SSO sign-out for FXA
       bug 969892: Some fixes to the test suite in bug 943521
       Bug 978896 watch() does not automatically login a signed-in user

   Gaia:
       bug 972645: Implement Reset Password Link or Screen for FxA
       bug 955945: Implement age verification screens for FxA Signup

Comment 14

5 years ago
Time running short and 8 blockers where we want 0. The two big issues are:

  1) no Settings review (stalled)
  2) the RP API is not done (progressing, but at risk)

Waiting for peer review:
  stalled:
    bug 949051: Sign up for Firefox Accounts in Settings
    bug 974108: Race condition in FxAccountsIACHelper
  new:
    bug 955945: Implement age verification screens for FxA Signup
    bug 947374: Certified and packaged apps should be able to declare assertion audience
Not yet r?:
  close:
    bug 945363: Provide SSO sign-out for FXA
    bug 969892: Some fixes to the test suite in bug 943521
    bug 978896 watch() does not automatically login a signed-in user
  > 0 issues:
    bug 971379: Allow certified and privileged apps to call mozID API outside an event handler

Comment 15

5 years ago
We got a Settings review! Big thanks to Arthur Chen for helping us out.

r? -> feedback, fixed, resubmitted by EOD:
  bug 949051: Sign up for Firefox Accounts in Settings
    Jared and Arthur are working closely
r?:
  bug 974108: Race condition in FxAccountsIACHelper
  bug 971379: Allow certified and privileged apps to call mozID API outside an event handler
  bug 947374: Certified and packaged apps should be able to declare assertion audience

Not yet r?:
  bug 945363: Provide SSO sign-out for FXA
  bug 978896: watch() does not automatically login a signed-in user

Comment 16

5 years ago
Almost there. Several bugs landed; 3 waiting for 2nd, 3d, or 4th review, one r? for first time.

in-test-suite:
  bug 978896: watch() does not automatically login a signed-in user
repeat r?:
  bug 949051: Sign up for Firefox Accounts in Settings
  bug 974108: Race condition in FxAccountsIACHelper
  bug 976002: Build time flag to enable/disable FxA
r?:
  bug 945363: Provide SSO sign-out for FXA

Comment 17

5 years ago
broke android test on landing, fix TBD:
  bug 976002: Build time flag to enable/disable FxA
r+ \o/:
  bug 949051: Sign up for Firefox Accounts in Settings
  bug 945363: Provide SSO sign-out for FXA
one last tweak for r+, maybe?:
  bug 974108: Race condition in FxAccountsIACHelper

Updated

5 years ago
Depends on: 989363
Depends on: 994887
Depends on: 994911
No longer depends on: 994911
Depends on: 994918

Updated

5 years ago
No longer depends on: 994918
Depends on: 994934
No longer depends on: 994934
No longer depends on: 994887
Whiteboard: [qa-] → [qa-] [dependency: marketplace]
Blocks: 1002704

Updated

5 years ago
Depends on: 1016069

Updated

5 years ago
Depends on: 1016070

Updated

5 years ago
No longer depends on: 1016070

Updated

5 years ago
No longer depends on: 1016069
Depends on: 1045712
No longer blocks: 1002704
I don't think we are going to work on this anymore. Closing.
Status: NEW → RESOLVED
Last Resolved: 9 months ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.