967878 - [Messages] Background doesn't scroll with the threads causing expensive over-invalidation

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::SMS, defect, P1)

Description

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

+++ This bug was initially created as a clone of Bug #967274 +++

This is the same issue as bug 950250 but for the Messages app. See that bug for more details

Comment 1

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: bug967878.patch

Comment 2

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 8370385 [details] [diff] [review]
bug967878.patch

Benoit I think I understood what you were looking for but I'm asking r? just to make sure.

Comment 3

[Rick Waldron [:rwaldron]]

Interesting—this seems like a platform issue.

Comment 5

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

(In reply to Rick Waldron [:rwaldron] from comment #3)
> Interesting—this seems like a platform issue.

It's because of how CSS is spec'ed. GFX/layout folks are thinking of doing an optimization in the platform but it is too short for 1.3.

Comment 6

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

I guess this is a 1.3 blocker. This is also a very safe patch.

Comment 7

[Julien Wajsberg [:julienw]]

Comment on attachment 8370385 [details] [diff] [review]
bug967878.patch

Review of attachment 8370385 [details] [diff] [review]:
-----------------------------------------------------------------

I'm not saying I understand everything, but well, I do see the effect.

::: apps/sms/style/sms.css
@@ +123,4 @@
>  }
>  
>  #threads-container[data-type="list"] ul {
> +  background-color: white;

I think we need a small comment explaining why we're adding this, with either a gecko bug # if you have it, or this bug #

Comment 8

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

master: https://github.com/mozilla-b2g/gaia/commit/dc10106b056acf573c04463122066fae8ae9cbb2

Comment 9

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

https://github.com/mozilla-b2g/gaia/commit/28f9dd73bccfafb62b6f883296ed42f2518e0fd9