967910 - "IO request failed : undefined" on My Dashboard

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: MyDashboard, defect)

Description

[Garrett Robinson [:grobinson]]

When I try to load My Dashboard with "You are CC'ed on" as the chosen query, I get a JS alert window that says "IO request failed : undefined". If I click OK, the pane of bugs on the left side remains empty. This just started happening in the past few days.

This may related to the number of bugs being returned by the query. If I change the "Choose query:" dropdown to "Assigned to You", then the panel of bugs loads correctly. Given that I'm CC'ed on many more bugs that I have assigned, and that number has been growing steadily, it makes sense that it may have crossed over some kind of boundary in the last day that causes this error.

This bug greatly decreases the usability of Bugzilla.

Comment 1

[Garrett Robinson [:grobinson]]

cc'ing myself on this bug for irony points.

Comment 2

[:glob ✱]

odd.  you're only cc'd on 72 bugs.  my CC list returns 752 bugs, which the dashboard displays without issue.
is there anything of interest the web console?

Comment 3

[Garrett Robinson [:grobinson]]

FWIW, "too many bugs breaks the dashboard" was an anecdotal hunch from a co-worker.

Comment 4

[Garrett Robinson [:grobinson]]

There's not much in the Web Console. All I see that could be relevant is a JS warning: "Use of attributes' specified attribute is deprecated. It always returns true." from dom-base-min.js.

After loading the page, I see the following request right before the error appears:

POST https://bugzilla.mozilla.org/jsonrpc.cgi

with the response body:

{"error":{"message":"When using JSON-RPC over GET, you must specify a 'method' parameter. See the documentation at http://www.bugzilla.org/docs/4.2/en/html/api/Bugzilla/WebService/Server/JSONRPC.html","code":32000},"id":"https://bugzilla.mozilla.org/","result":null}

Comment 5

[Josh Mize [:jgmize]]

I'm also seeing this happen. I think it might have to do with being CC'd on private bugs. Looking through the requests when loading My Dashboard, I see a POST to with the body

{"version":"1.1","method":"MyDashboard.run_bug_query","id":1,"params":{"query":"openccbugs"}}

which is getting a JSONRPCError code 110 with the message "Comment id 8367768 is private."

I'm not sure which bug the comment with that id belongs too, but it's probably private.

Comment 6

[:glob ✱]

Attachment: 967910_1.patch

- ignore private comments if the user isn't an insider
- fix the error reporting to display the actual error message

Comment 7

[Garrett Robinson [:grobinson]]

(In reply to Josh Mize [:jgmize] from comment #5)
> I'm also seeing this happen. I think it might have to do with being CC'd on
> private bugs. Looking through the requests when loading My Dashboard, I see
> a POST to with the body

That makes some sense, I'm cc'ed on a lot of private security bugs. Although I'm not sure why it would've just started happening recently, I've been cc'ed on security bugs pretty much since I started.

Comment 8

[David Lawrence [:dkl]]

Comment on attachment 8373903 [details] [diff] [review]
967910_1.patch

Review of attachment 8373903 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. r=dkl

Comment 9

[:glob ✱]

(In reply to Garrett Robinson [:grobinson] from comment #7)
> That makes some sense, I'm cc'ed on a lot of private security bugs. Although
> I'm not sure why it would've just started happening recently, I've been
> cc'ed on security bugs pretty much since I started.

the bug is triggered when the last comment on a bug is private, and you don't have visibility of private comments.  private comments are infrequent, but are more common on security bugs.


Committing to: bzr+ssh://[e-mail]/bmo/4.2/
modified extensions/MyDashboard/lib/WebService.pm
modified extensions/MyDashboard/web/js/flags.js
modified extensions/MyDashboard/web/js/query.js
Committed revision 9229.

Comment 10

[Garrett Robinson [:grobinson]]

Thanks, everyone! How long until the fix is deployed?

Comment 11

[Mark Côté [:mcote]]

Should go out tonight (pushes are generally Wednesday nights North-America time).

Comment 12

[:glob ✱]

this fix is now live.

Comment 13

[Garrett Robinson [:grobinson]]

Confirmed, the "CC'ed" query on my dashboard is working again. Thanks, everyone!