96804 - <embed>+width attribute overrides max-width style

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Phil Anderton]

See attachment. A <div> with style="max-width:50%" contains an <object> element
and an <embed> element, both with width=100%.
The <object> element displays with a width of 50%, as expected, whereas the
<embed> element uses the whole window width.

Comment 1

[Phil Anderton]

Attachment: HTML testcase

Comment 2

[karnaze (gone)]

Reassigning to av.

Comment 3

[Phil Anderton]

Attachment: One-line patch

Comment 4

[Phil Anderton]

I've just attached a patch which I believe fixes the problem.

Comment 5

[Christopher Hoess (gone)]

Adding patch, review keywords.  Reporter: please follow the procedure outlined
at http://www.mozilla.org/hacking/ to help get this patch reviewed and checked in.

Comment 6

[Peter Lubczynski]

Marc, what do you think?

Comment 7

[Marc Attinasi]

Well, it looks correct - objectFrames *are* replaced elements. Has anybody
tested this (I'm guessing that the contributor did, but please document tests /
results).

Comment 8

[Phil Anderton]

I have indeed tested it - against the attached test case and a few more
realistic examples. As you say, objectFrames are replaced elements, so setting
isReplaced must be the right thing to do. I don't see why <embed> should be any
different from <object> or <applet> in this respect.

Comment 9

[Peter Lubczynski]

r=peterl

Comment 10

[Marc Attinasi]

Comment on attachment 48019 [details] [diff] [review]
One-line patch

sr=attinasi

Comment 11

[av (gone)]

Checked in. Thanks everybody.