968177 - Speed up bookmarks.html export by using the shared backups code

Status: RESOLVED FIXED

(Toolkit :: Places, defect)

Description

[Marco Bonardo [:mak]]

We can reuse the code I'm introducing in bug 824433 for bookmarks.html, this will have other advantages like exporting guids and tags in the html format and using OS.File, with a relatively low cost (since the shared code is already there)

Comment 1

[Marco Bonardo [:mak]]

Attachment: wip

Comment 2

[Marco Bonardo [:mak]]

Attachment: patch v1

Comment 3

[Marco Bonardo [:mak]]

note I verified that IE can properly import the generated file

Comment 4

[Marco Bonardo [:mak]]

note to self: remember to remove pre-processing from BookmarksHTMLUtils.jsm

Comment 5

[Marco Bonardo [:mak]]

Attachment: patch v1.1

removed preprocessing

Comment 6

[Asaf Romano (gone)]

Comment on attachment 8373347 [details] [diff] [review]
patch v1.1

Review of attachment 8373347 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good.

::: toolkit/components/places/BookmarkHTMLUtils.jsm
@@ +115,5 @@
> +
> +/**
> + * Gets [faviconURI, dataLen, data, mimeType] for a given page url.
> + */
> +function promiseFaviconData(aPageUrl) {

It's probably a good idea to have it in PlacesUtils alongside similar methods

@@ +164,5 @@
>    /**
>     * Saves the current bookmarks hierarchy to a "bookmarks.html" file.
>     *
> +   * @param aFilePath
> +   *        OS.File path for the "bookmarks.html" file to be created.

Since it's just a file path string, I wouldn't mention OS.File.

Comment 7

[Marco Bonardo [:mak]]

Attachment: patch v1.2

Comment 8

[Marco Bonardo [:mak]]

Attachment: patch v1.3

correct changes :/

Comment 9

[Marco Bonardo [:mak]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e89b4d98aa53

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/e89b4d98aa53