968341 - Initial sync for clients added to an existing account should not set next sync to 24 hours

Status: VERIFIED FIXED

(Firefox :: Sync, defect)

Description

[Tracy Walker [:tracy]]

When adding additional clients to an existing account the initial sync should not set the next sync 24 hours. eg. Sync.SyncScheduler	DEBUG	Next sync in 86400000 ms.

It should be setting itself immediateInterval (90 seconds) or activeInterval (10 minutes). Most likely immediateInterval.

Comment 1

[Richard Newman [:rnewman]]

I'd flip this around a little bit: newly-added clients should schedule a sync for a few minutes later, and they'll switch into the right mode automatically. (Optimally it would sync immediately after the other devices on the account.)

Related problem: if the *first* device you use is a desktop, then you add another device, the first device won't know it's now in a multi-device scenario until the next day. Unlike with the pairing flow, there's no way to notify it to switch.

It might be worth dropping the single-device interval down to something smaller.

Comment 2

[Tracy Walker [:tracy]]

Sync Now on both clients is not changing the interval.  Both clients think it is a single-device.   Auto-sync is blocked by this.

Comment 3

[Richard Newman [:rnewman]]

(In reply to [:tracy] Tracy Walker - QA Mentor from comment #2)
> Sync Now on both clients is not changing the interval.  Both clients think
> it is a single-device.   Auto-sync is blocked by this.

And they're syncing to exactly the same storage server URL?

Can you paste the POST /.../clients log lines from each client?

What's the value of

  services.sync.client.GUID

on each client?

Comment 4

[Tracy Walker [:tracy]]

In client I see history sync from client to client but nothing else.

client A:
1391627417354	Sync.Collection	DEBUG	mesg: POST success 200 https://sync-2-us-east-1.sync.services.mozilla.com/1.5/10400/storage/history
1391627417354	Sync.Collection	DEBUG	POST success 200 https://sync-2-us-east-1.sync.services.mozilla.com/1.5/10400/storage/history

clientB:
1391629131383	Sync.Collection	DEBUG	mesg: POST success 200 https://sync-2-us-east-1.sync.services.mozilla.com/1.5/10400/storage/history
1391629131383	Sync.Collection	DEBUG	POST success 200 https://sync-2-us-east-1.sync.services.mozilla.com/1.5/10400/storage/history

in every sync log, both clients show: 
1391628803723	Sync.Synchronizer	DEBUG	Refreshing client list.
1391628803723	Sync.Engine.Clients	INFO	0 outgoing items pre-reconciliation
1391628803724	Sync.Engine.Clients	INFO	Records: 0 applied, 0 successfully, 0 failed to apply, 0 newly failed to apply, 0 reconciled.
1391628803724	Sync.Synchronizer	INFO	Updating enabled engines: 1 clients.

Comment 5

[Ryan Kelly [:rfkelly]]

Likely due to Bug 968512 which was causing the clients to not correct fetch other client's records.

Comment 6

[Ryan Kelly [:rfkelly]]

The "next sync in" numbers look better for me after deploying fix in Bug 968512, please re-test against latest prod servers.

Comment 7

[Tracy Walker [:tracy]]

(In reply to Ryan Kelly [:rfkelly] from comment #6)
> The "next sync in" numbers look better for me after deploying fix in Bug
> 968512, please re-test against latest prod servers.

yes, works with Nightlies from 20140207 mrking fixed by 968512.  

note: I filed bug 969555 to reduce the singleDevice interval to something shorter than 24 hours so the initial client on an account can catchup to syncing with other devices sooner.