don't compress web app zips for engineering builds

RESOLVED WONTFIX

Status

RESOLVED WONTFIX
5 years ago
7 months ago

People

(Reporter: dietrich, Assigned: dietrich)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
10:39 < lightofapollo|baby]]> dietrich: https://github.com/mozilla-b2g/gaia/blob/master/build/webapp-zip.js#L35 <-
10:40 < lightofapollo|baby]]> dietrich: there is a 2~ minute savings if that is NONE during development
10:40 < dietrich]]> could we do that for engineering builds?
10:40 < lightofapollo|baby]]> dietrich: yes
10:41 < lightofapollo|baby]]> dietrich: compression is great but we only really need it when flashing the phone
10:44 < dietrich]]> lightofapollo|baby: hm i flash eng builds onto my phones. so maybe only don't compress when we know profile is on desktop?
10:46 < lightofapollo|baby]]> dietrich: yeah (and then default that to on in the integration tests)
(Assignee)

Comment 1

5 years ago
Created attachment 8370955 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/16001

Here's a start.

How do integration tests need to control this? Should I push the config out to the makefile instead?
Attachment #8370955 - Flags: feedback?(jlal)
(Assignee)

Updated

5 years ago
Assignee: nobody → dietrich

Comment 2

7 months ago
Firefox OS is not being worked on
Status: NEW → RESOLVED
Last Resolved: 7 months ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.