Closed Bug 968382 Opened 7 years ago Closed 7 years ago

software home button doesn't work when rocketbar is active

Categories

(Firefox OS Graveyard :: Gaia::System::Browser Chrome, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::System::Browser Chrome
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: dietrich, Assigned: kgrandon)

References

Details

Attachments

(1 file)

Github pull request
46 bytes, text/x-github-pull-request
alive
: review+
Details | Review 
Nexus 4 has software home button.

STR:

1. open rocket bar

2. hit home button to close it (because cancel is tiny and very far to stretch my fingers)

Expected: go home

Actual: nothing
Attached file Github pull request —
Assignee: nobody → kgrandon
Status: NEW → ASSIGNED
Attachment #8371379 - Flags: review?(alive)
Comment on attachment 8371379 [details] [review]
Github pull request

Keep in mind that we should shrink the rocketWindow or searchWindow according to LayoutManager.height in the long term. Please note this in rocketbar rewrite or file follow up bug.
Attachment #8371379 - Flags: review?(alive) → review+
I will file a follow-up, thanks!
Landed: https://github.com/mozilla-b2g/gaia/commit/178710ea19bab97f57351656075f5ab3a4aaef81
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.