968461 - Bug 942164 broke building ESR24 with gcc 4.4

Status: RESOLVED FIXED

(Core :: Graphics: ImageLib, defect)

Description

[Mike Hommey [:glandium]]

We're still supporting ESR24 building with gcc 4.4, and in that case it doesn't build in C++11 mode, which means >> is not allowed for something other than a shift.

Comment 1

[Mike Hommey [:glandium]]

Attachment: Fix imgStatusTracker.h to build with gcc 4.4

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 942164
User impact if declined: Failure to build with gcc 4.4, which is a supported setup for ESR24 (last release to support building with gcc 4.4)
Testing completed (on m-c, etc.): Tested by building 24.3 with the patch applied on debian oldstable
Risk to taking this patch (and alternatives if risky): It's a trivial patch adding a missing space (from C++03 POV).
String or IDL/UUID changes made by this patch: None

Comment 2

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8371115 [details] [diff] [review]
Fix imgStatusTracker.h to build with gcc 4.4

Did you landed to m-c yet?

Comment 3

[Mike Hommey [:glandium]]

We don't support building as C++03 on m-c.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/8607f5696d5e

Do we need this on other branches too?

Comment 5

[Mike Hommey [:glandium]]

Comment on attachment 8371115 [details] [diff] [review]
Fix imgStatusTracker.h to build with gcc 4.4

Dammit, I meant to request esr24? not aurora? See comment 1.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr24/rev/84e6fca96f25