968573 - Refine interaction of clicks on dynamic panel items

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Awesomescreen, defect)

Description

[:Margaret Leibovic]

I think we should find a way to default to opening regular URLs in the fennec you're in, instead of offering (or automatically) opening the URL in a different browser.

Additionally, we should just open that URL in the tab you're in, instead of opening it in a new tab. Basically, I think we should match the behavior of our built-in panels.

Comment 1

[Lucas Rocha (:lucasr)]

(In reply to :Margaret Leibovic from comment #0)
> I think we should find a way to default to opening regular URLs in the
> fennec you're in, instead of offering (or automatically) opening the URL in
> a different browser.

This is not necessarily going to be opened in a "browser" btw. It all comes down to the intent URL patterns that the apps you have in your device are tracking. For example, the Twitter app tracks http://twitter.com/* URLs, YouTube tracks http://youtube.com/* URLs, and so on.

IIRC, our plan for that was to have a panel view option to toggle between 'intent' or 'browser'. Something along the lines of:

ItemHandler {
  INTENT: "intent",
  BROWSER: "browser"
}

{ type: Home.panels.View.LIST,
  dataset: "somedatasetid",
  itemHandler: Home.panels.ItemHandler.INTENT }

The default value being Home.panels.ItemHandler.BROWSER.

Thoughts?

Comment 2

[:Margaret Leibovic]

That sounds good, I didn't see a bug filed about this plan, so we can use this one.

I agree the default should just be to open the URL in the browser, and I think the behavior here should be to open it in the current tab.

Allowing the add-on to launch an intent is a nice option, but I think that should be deliberately specified by the add-on. The API you proposed seems reasonable to me.

Comment 3

[Wesley Johnston (:wesj)]

Probably out of scope, but there are these intent uri things in Android. I started to support them at one point in bug 851693, and need to finish it (with some UI to prompt the user).

On the other hand, building them isn't something I'd expect addon authors to know about, but its not that difficult. i.e. see the source here:

http://androidxref.com/4.2.2_r1/xref/frameworks/base/core/java/android/content/Intent.java#6515

Comment 4

[Lucas Rocha (:lucasr)]

Attachment: Introduce ItemType into HomeConfig/Home.jsm (r=margaret)

Comment 5

[Lucas Rocha (:lucasr)]

Attachment: Use ViewConfig's item handler to define url opener flags (r=margaret)

Comment 6

[Lucas Rocha (:lucasr)]

Comment on attachment 8375497 [details] [diff] [review]
Introduce ItemType into HomeConfig/Home.jsm (r=margaret)

Use BROWSER item handler by default.

Comment 7

[Lucas Rocha (:lucasr)]

Comment on attachment 8375498 [details] [diff] [review]
Use ViewConfig's item handler to define url opener flags (r=margaret)

There's an unfortunate code duplication here. We should be doing the item handler checks in PanelLayout instead. But doing this here will cause conflicts with jdover's patches in bug 929982, something I'd like to avoid at this point. 

I filed 972351 to fix the code duplication once the folder stuff lands.

Comment 8

[Lucas Rocha (:lucasr)]

Err, I meant jdover's patch in bug 942295.

Comment 9

[:Margaret Leibovic]

Comment on attachment 8375497 [details] [diff] [review]
Introduce ItemType into HomeConfig/Home.jsm (r=margaret)

Review of attachment 8375497 [details] [diff] [review]:
-----------------------------------------------------------------

Nice. Just make sure to update the commit message - I got confused because there is a separate bug about ItemType :) And we can also add this to the wiki docs, I need to update my add-ons to dogfood these new options we keep adding!

Comment 10

[:Margaret Leibovic]

Comment on attachment 8375498 [details] [diff] [review]
Use ViewConfig's item handler to define url opener flags (r=margaret)

Review of attachment 8375498 [details] [diff] [review]:
-----------------------------------------------------------------

This duplication makes me think of our comments in bug 968179. Glad you filed a follow-up.

Comment 11

[Lucas Rocha (:lucasr)]

https://hg.mozilla.org/integration/fx-team/rev/909bebfa48cd
https://hg.mozilla.org/integration/fx-team/rev/7af486d45b08

Comment 12

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/909bebfa48cd
https://hg.mozilla.org/mozilla-central/rev/7af486d45b08