968619 - [Settings] add marionette test for airplane mode

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Add one marionette test for airplane mode in Settings app.

Comment 1

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Attachment: patch on master

Hi Evan, 

can you give me some feedbacks to make sure I am on the right way ? Thanks :)

Comment 2

[Evan Tseng [:evanxd]]

Hi EJ,
I added comments in the PR.

Comment 3

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

@Evan,

I just addressed your comments and please kindly review my patch again ! THanks

Comment 4

[Evan Tseng [:evanxd]]

Hi EJ,

I added comments in the PR.

Comment 5

[Eddy Bruel [:ejpbruel]]

Fairly sure you got the wrong EJ :-)

Comment 6

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

@Eddy xDDDD, 

@Evan must type the name wrong by accident, sorry about that haha.

Comment 7

[Evan Tseng [:evanxd]]

Hi Eddy,

Sorry for that. :P

Comment 8

[Evan Tseng [:evanxd]]

Comment on attachment 8437558 [details] [review]
patch on master

Hi EJ,

Nice work. The patch looks good to me. And please make sure the patch works well without intermittent failures before we merge it. Thanks.

Comment 9

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Thanks Evan & all, this patch just got merged into Gaia/master: 51b5259f3718ec1b670e28512be173f5e78fc7a4