968640 - Lazy init HomeBanner using ViewStub

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Mark Finkle (:mfinkle) (use needinfo?)]

HomeBanner.<init> is showing up in our startup profiles. It's small, 1.1% (25ms), but it should not really need to inflate/init until we need to display it.

Comment 1

[:Margaret Leibovic]

Attachment: Lazy init HomeBanner using ViewStub

Luckily, this isn't one of the many home banner bugs we need to try to uplift, but I figured I would fix it while I'm working in this code.

Comment 2

[Lucas Rocha (:lucasr)]

Comment on attachment 8390758 [details] [diff] [review]
Lazy init HomeBanner using ViewStub

Review of attachment 8390758 [details] [diff] [review]:
-----------------------------------------------------------------

Nice.

::: mobile/android/base/home/HomeBanner.java
@@ +69,5 @@
>  
>      public HomeBanner(Context context, AttributeSet attrs) {
>          super(context, attrs);
>  
> +        LayoutInflater.from(context).inflate(R.layout.home_banner_content, this);

Forgot to include home_banner_content in the patch?

Comment 3

[:Margaret Leibovic]

(In reply to Lucas Rocha (:lucasr) from comment #2)
> Comment on attachment 8390758 [details] [diff] [review]
> Lazy init HomeBanner using ViewStub
> 
> Review of attachment 8390758 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Nice.
> 
> ::: mobile/android/base/home/HomeBanner.java
> @@ +69,5 @@
> >  
> >      public HomeBanner(Context context, AttributeSet attrs) {
> >          super(context, attrs);
> >  
> > +        LayoutInflater.from(context).inflate(R.layout.home_banner_content, this);
> 
> Forgot to include home_banner_content in the patch?

It was just an hg rename of home_banner.xml, you can see it if you look at the raw patch.

Comment 4

[:Margaret Leibovic]

https://hg.mozilla.org/integration/fx-team/rev/c25710dd68ff

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/c25710dd68ff