Closed Bug 968668 Opened 6 years ago Closed 6 years ago

Add Makefile for browser

Categories

(Firefox OS Graveyard :: Gaia::Build, defect)

x86
macOS
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: yurenju, Assigned: gduan)

References

Details

Attachments

(1 file)

add a makefile for browser and migrate browser related code from applications-data.js, webapp-manifest.js and webapp-optimize.js.

we should build this app in build_stage because code snippet in webapp-manifest.js modify manifest.webapp of browser, or we will see some modification in git.
Assignee: nobody → gduan
Comment on attachment 8372093 [details] [review]
PR to master

Hi Yuren,
please kindly review this patch. build and linter tests have passed.
Attachment #8372093 - Flags: review?(yurenju.mozilla)
Comment on attachment 8372093 [details] [review]
PR to master

Hi George, please check my comments on github.

also set review flag to Kevin Grandon to review build script for rocketbar.
Attachment #8372093 - Flags: review?(yurenju.mozilla) → review?(kgrandon)
George, Tim is discussing with me for naming issue on github[1], please take a look and come out a conclusion together.

[1] https://github.com/mozilla-b2g/gaia/pull/16085#discussion_r9573686
Comment on attachment 8372093 [details] [review]
PR to master

Looks good to me, but please fix Yuren's comments on github. Mine are optional :) 

Thanks!
Attachment #8372093 - Flags: review?(kgrandon) → review+
Comment on attachment 8372093 [details] [review]
PR to master

Hi Yuren,
could you also kindly help to review it?
Thanks.
Attachment #8372093 - Flags: review?(yurenju.mozilla)
Comment on attachment 8372093 [details] [review]
PR to master

George, r=yurenju if
1. extract defaultJson to default.json in browser/build/default.json
2. use initJson instead of initJSON
3. fix jshint and remove build.js from xfail.list
4. travis-ci is green.
Attachment #8372093 - Flags: review?(yurenju.mozilla) → review+
Thanks,
https://github.com/mozilla-b2g/gaia/commit/78875104731c6b7ec749b48ac3cdbc0099362472
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Blocks: 975964
Component: Gaia → Gaia::Build
You need to log in before you can comment on or make changes to this bug.