968668 - Add Makefile for browser

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Build, defect)

Description

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

add a makefile for browser and migrate browser related code from applications-data.js, webapp-manifest.js and webapp-optimize.js.

we should build this app in build_stage because code snippet in webapp-manifest.js modify manifest.webapp of browser, or we will see some modification in git.

Comment 1

[(Inactive after June) George Duan [:gduan] [:喬智]]

Attachment: PR to master

Comment 2

[(Inactive after June) George Duan [:gduan] [:喬智]]

Comment on attachment 8372093 [details] [review]
PR to master

Hi Yuren,
please kindly review this patch. build and linter tests have passed.

Comment 3

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Comment on attachment 8372093 [details] [review]
PR to master

Hi George, please check my comments on github.

also set review flag to Kevin Grandon to review build script for rocketbar.

Comment 4

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

George, Tim is discussing with me for naming issue on github[1], please take a look and come out a conclusion together.

[1] https://github.com/mozilla-b2g/gaia/pull/16085#discussion_r9573686

Comment 5

[Kevin Grandon :kgrandon]

Comment on attachment 8372093 [details] [review]
PR to master

Looks good to me, but please fix Yuren's comments on github. Mine are optional :) 

Thanks!

Comment 6

[(Inactive after June) George Duan [:gduan] [:喬智]]

Comment on attachment 8372093 [details] [review]
PR to master

Hi Yuren,
could you also kindly help to review it?
Thanks.

Comment 7

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Comment on attachment 8372093 [details] [review]
PR to master

George, r=yurenju if
1. extract defaultJson to default.json in browser/build/default.json
2. use initJson instead of initJSON
3. fix jshint and remove build.js from xfail.list
4. travis-ci is green.

Comment 8

[(Inactive after June) George Duan [:gduan] [:喬智]]

Thanks,
https://github.com/mozilla-b2g/gaia/commit/78875104731c6b7ec749b48ac3cdbc0099362472