968667 - Add run-app-js-command

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Build, defect)

Description

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

bug 964216 use js build module with commonjs in their own makefile, we should extract this function to a new macro then all app can use this macro in their makefile. when we add this macro, we can use it in makefile of keyboard app:

@$(call run-app-js-command, build)

and apps/keyboard/build/build.js will be executed.

Comment 1

[(Inactive after June) George Duan [:gduan] [:喬智]]

Attachment: PR to master

Migrate run-app-js-command to common.mk.

Comment 2

[(Inactive after June) George Duan [:gduan] [:喬智]]

Comment on attachment 8371324 [details] [review]
PR to master

Hi Yuren,
Please kindly review this patch.Thanks

Comment 3

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Comment on attachment 8371324 [details] [review]
PR to master

r=yurenju

Comment 4

[(Inactive after June) George Duan [:gduan] [:喬智]]

Thanks,
master: https://github.com/mozilla-b2g/gaia/commit/582230dc621033db69096e24a5c976e054d36c51

Comment 5

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Did you mean to close the bug?

Comment 6

[(Inactive after June) George Duan [:gduan] [:喬智]]

Thanks for reminding.
Close this bug.