Closed Bug 968667 Opened 6 years ago Closed 6 years ago

Add run-app-js-command

Categories

(Firefox OS Graveyard :: Gaia::Build, defect)

x86
macOS
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: yurenju, Assigned: gduan)

References

Details

Attachments

(1 file)

bug 964216 use js build module with commonjs in their own makefile, we should extract this function to a new macro then all app can use this macro in their makefile. when we add this macro, we can use it in makefile of keyboard app:

@$(call run-app-js-command, build)

and apps/keyboard/build/build.js will be executed.
Attached file PR to master
Migrate run-app-js-command to common.mk.
Comment on attachment 8371324 [details] [review]
PR to master

Hi Yuren,
Please kindly review this patch.Thanks
Attachment #8371324 - Flags: review?(yurenju.mozilla)
Comment on attachment 8371324 [details] [review]
PR to master

r=yurenju
Attachment #8371324 - Flags: review?(yurenju.mozilla) → review+
Assignee: nobody → gduan
Did you mean to close the bug?
Flags: needinfo?(gduan)
Thanks for reminding.
Close this bug.
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Flags: needinfo?(gduan)
Resolution: --- → FIXED
Blocks: 975964
Component: Gaia → Gaia::Build
You need to log in before you can comment on or make changes to this bug.