Closed Bug 968669 Opened 10 years ago Closed 10 years ago

Migrate code snippet for calendar customization from applications-data.js to apps/calendar/build/build.js

Categories

(Firefox OS Graveyard :: Gaia::Build, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Build
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: yurenju, Assigned: yurenju)

References

Details

Attachments

(1 file)

github PR: https://github.com/mozilla-b2g/gaia/pull/16065
46 bytes, text/x-github-pull-request
timdream
: review+
Details | Review 
add a makefile for calendar and migrate browser related code from applications-data.js.
sorry, s/browser/calendar/g
Assignee: nobody → yurenju.mozilla
Status: NEW → ASSIGNED
Summary: Add Makefile for calendar app → Migrate code snippet for calendar customization from applications-data.js to apps/calendar/build/build.js
Comment on attachment 8372034 [details] [review]
github PR: https://github.com/mozilla-b2g/gaia/pull/16065

Discussed offline. Let's add some tests to assert the behavior!
Attachment #8372034 - Flags: review?(timdream)
Comment on attachment 8372034 [details] [review]
github PR: https://github.com/mozilla-b2g/gaia/pull/16065

Added integration test to verify apps/calendar/js/presets.js.
Attachment #8372034 - Flags: review?(timdream)
Attachment #8372034 - Flags: review?(timdream) → review+
Travis is green.

master: https://github.com/mozilla-b2g/gaia/commit/764a743fd672628ff603fb4c91cec68e37254d90
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Blocks: 975964
Component: Gaia → Gaia::Build
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: