Closed Bug 968690 Opened 10 years ago Closed 10 years ago

Add Makefile for sms app

Categories

(Firefox OS Graveyard :: Gaia::Build, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Build
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: yurenju, Assigned: gduan)

References

Details

Attachments

(1 file)

PR to master
46 bytes, text/x-github-pull-request
yurenju
: review+
Details | Review 
add a makefile for sms and migrate sms related code from applications-data.js
Assignee: nobody → gduan
Attached file PR to master — 
waiting for travis
Comment on attachment 8374565 [details] [review]
PR to master

Hi Yuren,
could you kindly help to review this patch?
Thanks.
Attachment #8374565 - Flags: review?(yurenju.mozilla)
Attachment #8374565 - Flags: feedback?
Comment on attachment 8374565 [details] [review]
PR to master

r=yurenju if nit is address.
Attachment #8374565 - Flags: review?(yurenju.mozilla)
Attachment #8374565 - Flags: review+
Attachment #8374565 - Flags: feedback?
Thanks,
merge into master
https://github.com/mozilla-b2g/gaia/commit/10fcd3264f12cf68067cfadb935f3d86eef62ffe
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Blocks: 975964
Component: Gaia → Gaia::Build
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: