968694 - [settings] add marionette test for root panel

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[[e-mail]]

Overview Description:

Add marionette test for USB storage panel


Steps to Reproduce:
1) run make test-perf APP=settings
2) run make test-integration APP=settings


Actual Results:

No such integration test for USB storage panel


Expected Results:

Write that integration test and make test pass

Reproducibility:

100%

Additional Information:

Please refer to bug 956210 for more information.

Comment 1

[Arthur Chen [:arthurcc][inactive after 6/30]]

Attachment: Link to https://github.com/mozilla-b2g/gaia/pull/19026

Waiting for travis.

Comment 2

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8418664 [details]
Link to https://github.com/mozilla-b2g/gaia/pull/19026

Stable test passed. Evelyn and Evan, could you help review the patch? Thanks.

Comment 3

[Evelyn Hung]

Comment on attachment 8418664 [details]
Link to https://github.com/mozilla-b2g/gaia/pull/19026

more than happy to add tests. Thanks! :)

Comment 4

[Evan Tseng [:evanxd]]

Hi Arthur,

Sorry, I was busy on Calendar visual refresh.

I will take a look today.

Comment 5

[Arthur Chen [:arthurcc][inactive after 6/30]]

Thanks!

Comment 6

[Evan Tseng [:evanxd]]

Hi Arthur,
I added comments for the patch.
Check it out.

Comment 7

[Arthur Chen [:arthurcc][inactive after 6/30]]

Thanks for reviewing. I've updated the patch and the test has been passed 100 times. Would you mind have a look?

Comment 8

[Evan Tseng [:evanxd]]

Comment on attachment 8418664 [details]
Link to https://github.com/mozilla-b2g/gaia/pull/19026

Hi Arthur,

r+, nice works!
Just has a nit at https://github.com/mozilla-b2g/gaia/pull/19026/files#diff-bee54a448ba0c1ba414f5ddec52b6fc2R13.

Comment 9

[Evan Tseng [:evanxd]]

master: e37d56482706b57082af3f24dc912a30ba0ab7cb