Closed Bug 968697 Opened 6 years ago Closed 6 years ago

Add Makefile for system app

Categories

(Firefox OS Graveyard :: Gaia::Build, defect)

x86
macOS
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: yurenju, Assigned: gduan)

References

Details

Attachments

(1 file)

add a makefile for system and migrate system related code from applications-data.js, webapp-manifest.js and webapp-optimize.js.

we should build this app in build_stage because code snippet in webapp-manifest.js modify manifest.webapp of browser, or we will see some modification in git.
(In reply to Yuren [:yurenju][:小朱] from comment #0)
> add a makefile for system and migrate system related code from
> applications-data.js, webapp-manifest.js and webapp-optimize.js.
webapp-optimize.js should be webapp-zip.js
Assignee: nobody → gduan
Attached file PR to master
waiting for travis
Comment on attachment 8373243 [details] [review]
PR to master

Hi Yuren,
please kindly review this patch, thanks.
Attachment #8373243 - Flags: review?(yurenju.mozilla)
Comment on attachment 8373243 [details] [review]
PR to master

r=yurenju, thank you George, you are taking a lot of bug for refactoring!! :D
Attachment #8373243 - Flags: review?(yurenju.mozilla) → review+
Thanks!
master: https://github.com/mozilla-b2g/gaia/commit/e1f25104cf8085eb78b3830b42e499af4da95fc5
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Blocks: 975964
Component: Gaia → Gaia::Build
You need to log in before you can comment on or make changes to this bug.