968697 - Add Makefile for system app

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Build, defect)

Description

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

add a makefile for system and migrate system related code from applications-data.js, webapp-manifest.js and webapp-optimize.js.

we should build this app in build_stage because code snippet in webapp-manifest.js modify manifest.webapp of browser, or we will see some modification in git.

Comment 1

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

(In reply to Yuren [:yurenju][:小朱] from comment #0)
> add a makefile for system and migrate system related code from
> applications-data.js, webapp-manifest.js and webapp-optimize.js.
webapp-optimize.js should be webapp-zip.js

Comment 2

[(Inactive after June) George Duan [:gduan] [:喬智]]

Attachment: PR to master

waiting for travis

Comment 3

[(Inactive after June) George Duan [:gduan] [:喬智]]

Comment on attachment 8373243 [details] [review]
PR to master

Hi Yuren,
please kindly review this patch, thanks.

Comment 4

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Comment on attachment 8373243 [details] [review]
PR to master

r=yurenju, thank you George, you are taking a lot of bug for refactoring!! :D

Comment 5

[(Inactive after June) George Duan [:gduan] [:喬智]]

Thanks!
master: https://github.com/mozilla-b2g/gaia/commit/e1f25104cf8085eb78b3830b42e499af4da95fc5