96877 - Address book: Lists lose addresses.

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Address Book & Contacts, defect, P1)

Description

[Bjorn Granfeldt]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:0.9.3) Gecko/20010801
BuildID:    2001080104

After creating a mail group (list), you loose one,many or even ALL the items in
that list, after you close the list edit window, or between sessions in the browser.
The items sometimes seems to be left in the mab files, but in a severly trashed
state.

Reproducible: Always
Steps to Reproduce:
1. Create random named list.
2. Add names by either drag'n'drop or typing.
3. Close. Reopen. items lost.


Actual Results:  You loose your address list contents.

Expected Results:  Keep the contents in the list.

Comment 1

[Nathan Bidwell]

WFM on windows...  I will test later on Linux.

Comment 2

[Nathan Bidwell]

Works for me 20011005114 Linux

Bjorn, are you still seeing this?

Comment 3

[Michael D. Beynon]

This fails for me on all recent (including 2001100822) builds.

SunOS ringworm.cs.umd.edu 5.6 Generic_105181-21 sun4u sparc SUNW,Ultra-5_10

Mike.

Comment 4

[John Fredlund]

I see something like this on recent Win98 builds. New mailing list loses all but
one address in editing window upon closing and reopening. Editing old list had
same effect, but I am not going to try that again unless I have time to backup
and restore :-). Not sure what the relationship between names shown in the
editing window and actual names on the list is, but I am pretty sure it is not
one to one.

Comment 5

[Derek Lee]

I would like to confirm this bug for Mozilla 0.9.5 and 0.9.6 (2001112012) on
Linux, installed using the installer package.

My symptoms are very similar, but not identical.
I can create a list with NEW addresses which are not already in the address book.
Addresses which are already there fail to be included in a list. 

So, I guess a workaround is not to have anyone in more than one list,
and then delete the entries which already exist and start over again.

Comment 6

[Keyser Sose]

Marking nEW.

Comment 7

[scottputterman]

reassigning to racham.

Comment 8

[Ninoschka Baca]

Trunk build 2001-12-13-03: WinMe, ok.
Trunk build 2001-12-13: Linux RH 7.1, ok.

Can anyone who still sees the problem reproduce this in a new profile?

Comment 9

[John Fredlund]

Still reproduces for me (created new profile, clean install) build 2001121403,
Win98SE.

Comment 10

[Derek Lee]

Build 2001121606 Linux i686 on RedHat 7.2

Still happens to me, even with a brand new profile.
I should point out that, when I create a new list using a mixture of addresses
which are new and old to my address book, only the new addresses survive
after I closed the Address Book window and restart it. The old addresses simply
do not appear in the list afterwards...

Comment 11

[mark a. foltz]

Build 2001122108 on Linux / RedHat 7.1

Still happening for me, too.

I made an address list, added some names to it, then reopened it later by double
clicking.  Only some of the original names remained.

Another problem is that when i single-click on the list in the address book
sidebar, no addresses appear in the main pane.  only by double-clicking on the
list to pull up the property sheet do i see any addresses at all.

Comment 12

[Andi Gettys]

Using Windows ME, Build ID: 2001122106 
I typed addresses into a LIST, closed window, reopened the 
window, typed in some additional ones,
came back and it had lost the additional ones. In my case
it seems to keep 19 addresses. I can see them as long as
I have the address book open. Once I close it and come
back, the additional addresses are gone. Also a change I
made to one of the original addresses has disappeared.
Don't know if it's related but the scroll bar on the address list
window is flaky and jumps around too. 

Comment 13

[(not reading, please use [e-mail] instead)]

taking,  I've got a bunch of mailing list (bad) bugs on my radar for nsbeta1.

Comment 14

[Howard M. Stark]

I have had the same experiences. I think it is associated with upper case
letters in the email address.If the email address is changed to just lowercase
it seems to work fine for me.

Comment 15

[Derek Lee]

Moz 0.9.7 Build 2002012208 Linux i686 on RedHat 7.2

The disappearing addresses in new list appear to have been fixed.
I can now make up a new mailing list from old and new email addresses alike :-)
(see comment 10)

But I can reproduce the problem experienced by Mark (comment 14)
when I add an existing email address from my address book to a new list.
If the email address itself has capital letters, the result is that:
(1) a *new* card is added to the original address book, with just the email and
no other info.
(2) this new card is the one that the mailing list links to.

Comment 16

[Simon Spiegel]

I don't know if this is exactly the same bug, but for me adress list is almost
completely useless (using build 2002020409) . I'm unable to create a list with
more than 12 or 13 entries. While I can enter as many adresses as I want, it
wont display them in list view. I regurlay get the same adressed displayed twice
although I've entered it only once. This is really a major bug. 

Comment 17

[Steve Hall]

Adding to cc:

Comment 18

[Raul Pinto]

I just installes the latest nightly (2002021803) on my Win2k-Machine. I tested
the adress book, for any dependencies... but didn't find any.

Description: The problem is, that there's a difference between the listing when
clicking on the list and showing its properties. I didn't test which one is
taken when sending an e-mail to a list.

Testing purpose: Look for a server or set up one by oneself (not me, sorry).
Know which adresses are NOT taken, then create a list with those adresses and
edit the mail-list. So that there's a difference between the properties and the
displayed adresses. Then see by the "no recipient"-reply of the server whether
the displayed or the property list is taken.

I doesn't depend on the size of the lists. My adress book has 137 entries, the
first list ("Theatergruppe") has 8 entries, the second ("Witze-Verteiler") has
25 and the last one ("Klassenliste") 3. My collected Adresses has 1524 entries.
I can't edit the lists without destroying them. As soon as I add a contact, it's
not displayed, but in the properties. But when I close and re-open the
adressbook, the "name" tab is cleared but the e-mail-adress is still there.

Hope, this has helped you to come a bit forward...

thx
   Graphity

Comment 19

[Ninoschka Baca]

Bug# 117996 covers the problem with Drag and drop of card to mailing list adds a 
duplicate card, if email address contains capital letter.

Regarding comment 18: I can duplicate the problem where a list is selected in 
the directory pane (dir pane) and the cards in the results pane (right pane) do 
not match the cards in the mail list dialog.

Steps to reproduce:
a. With an AB selected in the dir pane Create a list with 3 entries
b. With the AB selected change the address of one of the cards (i.e. from 
[e-mail] to [e-mail])
c. With the AB selected, then select the list in the result pane and the card 
pane (below) still shows the old entry ([e-mail]).
d. Select the list in the dir pane and the results pane appears to have taken 
the change because it shows [e-mail].
e. With the list still selected in the dir pane, select the Properties button to 
display the list dialog and it shows the old entry [e-mail].
f. Close the list and another card is added to the results pane which only 
includes the email [e-mail]
g. In the dir pane switch to the AB then back to the list and now the card which 
had [e-mail] is gone and the card for jenny.com remains.

Expected Results: If the main card is edited shouldn't it be reflected in the 
list automatically? I would expect the link between the two to remain.

Screen shots to follow...

Comment 20

[Ninoschka Baca]

Attachment: c. card pane still shows [e-mail]

Comment 21

[Ninoschka Baca]

Attachment: still shows old entry, [e-mail]

Correction: The previous screen shot just shows the list right after it was
created which is ok. This screen shot shows that the list is not updated when
the email address is changed to [e-mail].

Comment 22

[Ninoschka Baca]

Attachment: list selected in dir pane, entries in results pane are ok

Comment 23

[Ninoschka Baca]

Attachment: open the list and it still displays [e-mail]

Comment 24

[Ninoschka Baca]

Attachment: close the list and [e-mail] added to results pane

Comment 25

[Ninoschka Baca]

Attachment: switch b/n AB and list, now card for [e-mail] is gone from results pane

Comment 26

[Ninoschka Baca]

Attachment: select AB & [e-mail] card still present but list still shows [e-mail]

Comment 27

[Ninoschka Baca]

Maybe comments 5 and 10 are related to bug# 128645. 

Comment 28

[saari (gone)]

nsbeta1- per ADT

Comment 29

[Raul Pinto]

I just saw, that the Target Milestone has been set to 1.2. I just can't believe,
that someone wants to release a ver 1.0 without beeing able to create Mailing Lists.
I just tried with 2002031104 to create a list, but it didn't work the way it
should. 
Please please fix this bug before 1.0. I think it's more important to have a
Bug-free program than a program released at its scheduled date...

thx
  Graphity

PS: Sorry for my bad english

Comment 30

[Simon Spiegel]

Lists are reallly unusable right now. If they don't get fixed for 1.0 please
disable them. This function is really an embaressement right now.

Comment 31

[(not reading, please use [e-mail] instead)]

moving in.  dataloss, so this should qualify for adt goodness.

working on AB turbo bugs right now, mailing lists are next.

Comment 32

[Derek Lee]

My problem in comment 15 is now fixed.
I also cannot reproduce comment 19.
(Linux i686 1.0rc2 build:2002052209)

Comment 33

[Michael Buckland]

Discussed in mail news bug meeting. Decided to plus this bug.

Comment 34

[Ninoschka Baca]

Marking nsbeta1 for reconsideration.

Comment 35

[Jo Hermans]

*** Bug 126153 has been marked as a duplicate of this bug. ***

Comment 36

[Jo Hermans]

*** Bug 166065 has been marked as a duplicate of this bug. ***

Comment 37

[Samir Gehani]

Mail triage team: nsbeta1+/adt2

Comment 38

[Cavin Song]

Is anyone still seeing this problem now (with the latest bild)? I had hard time 
reproducing it. If you do please let me know about the scenario(s) in which it 
is reproduced, that'll help me track doewn the problem. Thanks. I'm also 
interested in knowing if the members added to the list have email addresses or 
not, and if the email addresses include capital chars.

One problem I see is that if you remove the card (with email address) associated 
with a member from the database the member is NOT removed from the list. The 
list shows a member with all fields being empty instead.  Seems like a 
regression to me but not sure.

Comment 39

[Cavin Song]

Reassign.

Comment 40

[hjp]

I can still reproduce the bug with 1.3b (Build Id 2003021008) on Linux.
It behaves just the same as 1.2.1 (on both Linux and Windows)

The easiest way to produce it:

1) Create a new empty list

2) Double click on the list in the sidebar and enter a few email addresses with
   upper case characters

3) In the right pane, delete addresses one by one in random order. close the 
   address book in the side bar and reselect the list after each deletion.

4) At some point the right pane will show fewer addresses than you expect.
   However, if you double-click on the list, the popup-window will show all
   addresses (except those which you really deleted), and if you send mail
   it will go to all recipients. So it looks as if it is "only" a display 
   problem.

Comment 41

[mail]

I recently loaded 1.2 and gave it another shot.  This time it not only ate the
address list.....but also 1300 adresses in an address book....all of my buisness
contacts.  I've had it.  I won't be using Mozilla anytime soon again.

Comment 42

[Ninoschka Baca]

Trunk build 2003-03-13: Mac 10.1.5, WinME 
Using the steps in comment# 40 I was able to reproduce this easily. 

Comment 43

[Cavin Song]

The problem seems to be caused by that the list total in not decremented after
the target member card is removed. Because we replace the column of the deleted
member card with the last member card and then delete the column of the last
member card itself, if the list total count is not adjusted we end up failing
to locate the last member card next time another member card is deleted. For
example, when a list with 4 members are first created we have the following columns:

  Column String   Column Token   Row ID
  -------------   ------------   ------
    Address1         198           18
    Address2         199           19
    Address3         200           20
    Address4         201           21

After the 2nd member is deleted, we have:

    Address1         198           18
    Address2         199           21 <<--
    Address3         200           20

Now column token 199 points to RowID 21 which is the 4th/last member when the
list was initially created.  If we then delete another member card, say, the 1st
member, the code will try to locate the column token for the last member card
(ie, column string 'Address4') which will fail since it was removed during the
first deletion. We end up with the following:

    Address1         198            0 <<--
    Address2         199           21
    Address3         200           20

If the total count is correct (ie, 3 instead of 4) we'll have the following:

    Address1         198           20 <<--
    Address2         199           21

Comment 44

[Cavin Song]

Attachment: Proposed patch, v1

Reset total count after a member card is removed.

Comment 45

[(not reading, please use [e-mail] instead)]

Comment on attachment 118548 [details] [diff] [review]
Proposed patch, v1

r/sr=sspitzer

nice work, cavin!

Comment 46

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 118548 [details] [diff] [review]
Proposed patch, v1

a=dbaron for trunk checkin during 1.4alpha freeze, but in the future please use
the patch manager (rather than email) to request approval.

Comment 47

[Cavin Song]

Fix checked in.

Comment 48

[Ninoschka Baca]

Trunk build 2003-04-10: Mac 10.1.5, WinXP
Verified fixed using the steps described in comment# 40.