Closed
Bug 968968
Opened 12 years ago
Closed 11 years ago
Support Third Party remixurl values
Categories
(Webmaker Graveyard :: webmaker.org, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: cade, Assigned: cade)
References
Details
Attachments
(1 file)
When we render makes on webmaker.org, we just append '/remix' to the url.
While this works for our apps, we cannot expect any third party app to conform to this pattern. We already have remixurl on our makes, and have migrated our database of makes to use remixurl.
This bug will switch remix links to use the remixurl value.
The specific use case for this is Appmaker, which remixes apps in this fashion: 'appmaker.mozillalabs.com/remix?app=<url encoded app link>'
Yes, this means that links won't necessarily be "pretty" but, we committed to supporting makes from third party applications.
Assignee | ||
Updated•12 years ago
|
Flags: needinfo?(kate)
Assignee | ||
Comment 1•12 years ago
|
||
Kate / Cassie: any objections/concerns with not using the /remix method for linking to the remixurl?
Flags: needinfo?(cassie)
Comment 2•11 years ago
|
||
That seems fine to me. I think the language/affordances we use in the UI matter a lot more than the actual URL. It would be good to document the ability to add /remix to any URL somehow though
- K
Flags: needinfo?(kate)
Assignee | ||
Comment 3•11 years ago
|
||
Attachment #8373440 -
Flags: review?(kate)
Assignee | ||
Comment 4•11 years ago
|
||
(In reply to Kate Hudson (:k88hudson) from comment #2)
> It would be good to document the
> ability to add /remix to any URL somehow though
Perhaps we could add something to the make-details page?
Comment 5•11 years ago
|
||
Chris and I discussed this and there seem to be no real user-facing implications here, so I'm good with whatever you guys decide.
Flags: needinfo?(cassie)
Comment 6•11 years ago
|
||
Comment on attachment 8373440 [details] [review]
https://github.com/mozilla/webmaker.org/pull/596
Looks fine but can you rebase/run grunt? travis is barfing for some reason
Attachment #8373440 -
Flags: review?(kate) → review+
Assignee | ||
Comment 7•11 years ago
|
||
Wow, I forgot to close this one.
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•