Closed Bug 969030 Opened 7 years ago Closed 7 years ago

Remove the caller from document.all

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set
normal

Tracking

()

RESOLVED WONTFIX
mozilla30

People

(Reporter: Ms2ger, Assigned: Ms2ger)

References

Details

(Keywords: addon-compat, dev-doc-needed, site-compat)

Attachments

(1 file)

Removed from the spec in <https://www.w3.org/Bugs/Public/show_bug.cgi?id=22118>, based on results from Chrome that it's barely ever used.
Comment on attachment 8371805 [details] [diff] [review]
Remove support for calling document.all;

r=me
Attachment #8371805 - Flags: review?(bzbarsky) → review+
https://hg.mozilla.org/mozilla-central/rev/c8cd1f6b6d2d
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
This seems to have caused my online banking to stop working. They are using document.all("foo").

The site: https://www.crelan-online.be/eBankingII/?language=NL

You won't get the error if you cannot log in, but you can search for "document.all(" in https://www.crelan-online.be/eBankingII/js/script.min.js

Pushlog as determined by mozregression: https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=2e9aacb1d0d1&tochange=7133bb431eba

Do you want me to file a new (evangelism?) bug, or should this one be reopened?

As for context, this bank ranks 7th in Belgium. ("We're big in Belgium! Woo-hoo!") They have about 1.2 million customers.
Jan, thank you for catching that, and especially for the link to the script!  It's definitely blindly calling document.all.

Given comment 4 and https://groups.google.com/a/chromium.org/d/msg/blink-dev/urMtTTPpUro/S0HUaiOq_PIJ I think we should probably revert this change...  Ms2ger, care to do it?
Flags: needinfo?(Ms2ger)
https://hg.mozilla.org/integration/mozilla-inbound/rev/e494713ccc5a
Flags: needinfo?(Ms2ger)
Resolution: FIXED → WONTFIX
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.