Closed Bug 874212 Opened 7 years ago Closed 6 years ago

Move document.all to WebIDL

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla32

People

(Reporter: Ms2ger, Assigned: Ms2ger)

References

(Blocks 1 open bug)

Details

(Keywords: dev-doc-needed)

Attachments

(1 file)

No description provided.
Depends on: 874787
Depends on: 874788
Depends on: 877277
Depends on: 895728
Depends on: 909953
Depends on: 968766
Depends on: 969030
The static jsids in nsDOMClassInfo are newly unused, except for sEnumerate_id,
which was unused before.

This also removes the test_nondomexception.html test, which relied on an
obscure detail of the exception being thrown from document.all; I haven't
found another API which does something equally silly.
Attachment #8424807 - Flags: review?(bzbarsky)
Comment on attachment 8424807 [details] [diff] [review]
Move document.all to WebIDL

Please report a spec bug on the fact that item(5) will do the same thing as item("5") as the spec is written, whereas it should probably actually return the 6th element in the document...  The spec needs to actually overload item() on this interface, afaict.

Per spec, namedItem("") always returns null.  That's not what your new code (or our old code) does, afaict.  Followup, please, if I'm not missing something.

We need an implementation of GetSupportedNames.  Followup is OK, I guess.

Also, please file a spec bug on the "The HTMLAllCollection interface is used for generic collections of elements" business and removing the bits about the HTMLAllCollection possibly matching not all elements, since I think all that is gone now that the only HTMLAllCollection is document.all.

r=me with those bits filed.

r=me with those followups filed.
Attachment #8424807 - Flags: review?(bzbarsky) → review+
Depends on: 1013316
(In reply to Boris Zbarsky [:bz] from comment #2)
> Comment on attachment 8424807 [details] [diff] [review]
> Move document.all to WebIDL
> 
> Please report a spec bug on the fact that item(5) will do the same thing as
> item("5") as the spec is written, whereas it should probably actually return
> the 6th element in the document...  The spec needs to actually overload
> item() on this interface, afaict.

https://www.w3.org/Bugs/Public/show_bug.cgi?id=25817.

> Per spec, namedItem("") always returns null.  That's not what your new code
> (or our old code) does, afaict.  Followup, please, if I'm not missing
> something.

Bug 891952.

> We need an implementation of GetSupportedNames.  Followup is OK, I guess.

Bug 1013316.

> Also, please file a spec bug on the "The HTMLAllCollection interface is used
> for generic collections of elements" business and removing the bits about
> the HTMLAllCollection possibly matching not all elements, since I think all
> that is gone now that the only HTMLAllCollection is document.all.

https://www.w3.org/Bugs/Public/show_bug.cgi?id=25829.

> r=me with those bits filed.
> 
> r=me with those followups filed.

Thanks!
https://hg.mozilla.org/mozilla-central/rev/e50261fb6800
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
Adding dev-doc-needed, it looks there are some user facing changes.
Keywords: dev-doc-needed
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.