969051 - get_about_memory.py could automatically retrieve build settings from .userconfig

Status: RESOLVED FIXED

(Firefox OS Graveyard :: GonkIntegration, defect)

Description

[Ben Kelly [:bkelly, not reviewing]]

The get_about_memory.py script needs to know where the gecko object directory is to do things like fixup symbols in DMD reports.  Right now the user has to know to pass this information in with the --gecko-objdir argument.

We could make this a little bit easier if we had get_about_memory.py launch a shell process to read .userconfig and print out the resulting value of the $GECKO_OBJDIR.  The python code could then use that value to find the symbols.

Comment 1

[Eric Rahm [:erahm]]

This would also be useful for |--product|. I'm guessing we can do whatever |mach| does to work this stuff out, or if we're linux/mac only it should be pretty straightforward.

A super simple POC bash script:

#!/bin/bash
. load-config.sh
python tools/get_about_memory.py --gecko-objdir "${GECKO_OBJDIR}" "$@"

Comment 2

[Eric Rahm [:erahm]]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/B2G/pull/381

This patch attempts to deduce the --gecko-objdir and --product params used when processing DMD logs.

Comment 3

[Eric Rahm [:erahm]]

https://github.com/mozilla-b2g/B2G/commit/f0a118cc40ead852710bf409c3847d73250f403b