969221 - UITour may not correctly record telemetry if multiple pages are open with the same pageID and one is closed

Status: NEW

(Firefox :: Tours, defect, P5)

Description

[Blair McBride [:Unfocused] (UNAVAILABLE)]

From MattN's review in bug 952568 comment 15:

> ::: browser/modules/UITour.jsm
> @@ +325,5 @@
> > +          // Delete this from the window cache, so if the window is closed we
> > +          // don't expire this page ID twice.
> > +          let window = tab.ownerDocument.defaultView;
> > +          if (this.pageIDSourceWindows.get(window) == pageID)
> > +            this.pageIDSourceWindows.delete(window);
> 
> I think there is an issue if a user has multiple tour tabs open with the
> same page ID (likely more common after bug 966933) but I think that's an
> edge case that we probably don't need to worry much about.

Comment 1

[Matthew N. [:MattN]]

Moving open UITour bugs to Firefox::Tours. Filter on firefox-tours-20150121.