966933 - UITour: Add a UI tour link in the Help menu

Status: VERIFIED FIXED

(Firefox :: General, defect)

Description

[Zhenshuo Fang (:fang) - Firefox UX Team]

Add a link of the UI tour in the Help menu. There was a link in the help menu in the try build Blair provided us, and it worked really well. Some users actually went there to look for a tour. It would also benefit users who close the tour when they first saw it.

Comment 1

[:Gijs (he/him)]

This needs in-product strings. :-(

Comment 2

[Blair McBride [:Unfocused] (UNAVAILABLE)]

fang: Aurora is string-frozen - so generally we need to get any bugs that involve new strings landed *before* the merge to Aurora. In cases like this, we can land just the strings, and implement the actual functionality later on. But we really need to get the strings in one way or another, otherwise it makes it really difficult for the localizers.

Comment 3

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Attachment: Strings patch v1

Would like to double check the strings here before this gets landed, so hopefully you get back from lunch in time, fang :) But the train may leave without you.

Menu item label: Firefox Tour
Access key: o

Comment 4

[:Gijs (he/him)]

Comment on attachment 8369364 [details] [diff] [review]
Strings patch v1

Review of attachment 8369364 [details] [diff] [review]:
-----------------------------------------------------------------

r=me as far as the code is concerned.

Comment 5

[:Gijs (he/him)]

https://hg.mozilla.org/mozilla-central/rev/6be5d432b1b6

Comment 6

[Matthew N. [:MattN]]

We want to increase the priority of this so we can use it as a workaround for lack of bug 938079. Blair, are you able to get to this bug this week?

Comment 7

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Attachment: Patch v1

Alex: This is currently using the following URL:

  https://www.mozilla.org/%LOCALE%/firefox/%VERSION%/whatsnew/

Which works fine for Firefox 29, but Firefox 30 currently doesn't get the tour. Could we either make the same URL for 30 result in the tour page, or use a different URL for when someone manually opens the tour? Something like:
  https://www.mozilla.org/%LOCALE%/firefox/%VERSION%/tour/

(We can easily update this URL in future Firefox versions.)

Comment 8

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Erm. Alex, see comment 7.

Comment 9

[Alex Gibson [:agibson]]

(In reply to Blair McBride [:Unfocused] from comment #7)
> Created attachment 8385095 [details] [diff] [review]
> Patch v1
> 
> Alex: This is currently using the following URL:
> 
>   https://www.mozilla.org/%LOCALE%/firefox/%VERSION%/whatsnew/
> 
> Which works fine for Firefox 29, but Firefox 30 currently doesn't get the
> tour. Could we either make the same URL for 30 result in the tour page, or
> use a different URL for when someone manually opens the tour? Something like:
>   https://www.mozilla.org/%LOCALE%/firefox/%VERSION%/tour/
> 
> (We can easily update this URL in future Firefox versions.)

Yeah we should really have the tour available at a secondary URL for this purpose, as I'm guessing in the future /whatsnew pages may not always be a tour.

I'll create a bug to implement something along the lines of https://www.mozilla.org/%LOCALE%/firefox/%VERSION%/tour/.

Comment 10

[:Gijs (he/him)]

Comment on attachment 8385095 [details] [diff] [review]
Patch v1

Review of attachment 8385095 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM!

Comment 11

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Comment on attachment 8385095 [details] [diff] [review]
Patch v1

Thanks Gijs.

Will update the URL and land when bug 979217 goes live. Marking this patch obsolete to ensure no one accidentally lands it in the meantime.

Comment 12

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Attachment: Patch v1.1

Comment 13

[Alex Gibson [:agibson]]

The new URL discussed in comment 9 is now on prod:

https://www.mozilla.org/en-US/firefox/29.0a2/tour/
https://www.mozilla.org/en-US/firefox/30.0/tour/

Comment 14

[Blair McBride [:Unfocused] (UNAVAILABLE)]

https://hg.mozilla.org/integration/fx-team/rev/50042889c775

Comment 15

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Comment on attachment 8386018 [details] [diff] [review]
Patch v1.1

[Approval Request Comment]
Bug caused by (feature/regressing bug #): None
User impact if declined: No manual access to Australis tour, other than knowing the URL
Testing completed (on m-c, etc.): Manual testing
Risk to taking this patch (and alternatives if risky): Minimal. 
String or IDL/UUID changes made by this patch: None, strings already landed before Aurora merge

Comment 16

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/50042889c775

Comment 17

[Blair McBride [:Unfocused] (UNAVAILABLE)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/bcda1e3e802b

Comment 18

[svbabukumar]

I can still see the static page on navigating to the Help --> Firefox tour."https://www.mozilla.org/en-US/firefox/29.0/tour/" as specified in the bug history it is expected to display the page with content as displayed in the page "https://www.mozilla.org/en-US/firefox/central/"

29 -> Not Fixed
30 -> Not Fixed
31 -> Not Fixed

Comment 19

[Matthew N. [:MattN]]

All versions 29 and higher should show the interactive tour not, a page like /firefox/central/. Does this help?

Comment 20

[Carol Chung[:lizardwalk5]]

[bugday-20140409]

status-firefox29.0b6 verified
status-firefox30.0a2 verified
status-firefox31.0a1 verified

Testing on x86 Mac OSX 10.9.2
  Firefox 29.0b6 (2014-04-07)
  Aurora 30.0a2 (2014-04-09)
  Firefox Nightly 31.0a1 (2014-04-09)

If I click Help > * Tour, I'm redirected to this URL with an interactive tour (for respective versions):
  https://www.mozilla.org/en-US/firefox/29.0/tour/
  https://www.mozilla.org/en-US/firefox/30.0a2/tour/
  https://www.mozilla.org/en-US/firefox/31.0a1/tour/

* - (Firefox, Aurora, Nightly)

Comment 21

[Francesca Ciceri [:madamezou]]

As the previous commenter said, (comment 20), clicking on Help → Tour redirects me to the https://www.mozilla.org/en-US/firefox/$version/tour/ URL, where the tour starts.

Testing on x86_64 Linux (Debian Sid):

- verified on Nightly [Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Firefox/31.0 ID:20140408030205 CSet: 8883360b1edb]

- verified on Aurora [Mozilla/5.0 (X11; Linux x86_64; rv:30.0) Gecko/20100101 Firefox/30.0 ID:20140409004002 CSet: e450e07e3a58]

- verified on Beta [Mozilla/5.0 (X11; Linux x86_64; rv:29.0) Gecko/20100101 Firefox/29.0 ID:20140407135746 CSet: 71439d266704]

Comment 22

[Catalin Varga [QA][:VarCat]]

Marking the bug as verified per comment 20 and comment 21.