Closed
Bug 969446
Opened 10 years ago
Closed 10 years ago
Backout --hide-subtests option since bug 937181 implemented the same thing but better
Categories
(Testing :: Mochitest, defect)
Testing
Mochitest
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: ahal, Assigned: ahal)
References
Details
Attachments
(1 file)
13.44 KB,
patch
|
jmaher
:
review+
|
Details | Diff | Splinter Review |
I'll need to test it out on Ash or somewhere to make sure the log files don't jump up to 50mb again.
Assignee | ||
Comment 1•10 years ago
|
||
Here's the ash-mozharness backout: http://hg.mozilla.org/users/asasaki_mozilla.com/ash-mozharness/rev/a64955bf0e14 Watching the b2g desktop mochitest retriggers of: https://tbpl.mozilla.org/?tree=Ash&showall=1&rev=d619310b8b48
Assignee: nobody → ahalberstadt
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•10 years ago
|
||
The logs are slightly bigger, though still only 300kb, so looks like I can back it out.
Assignee | ||
Comment 3•10 years ago
|
||
https://hg.mozilla.org/build/mozharness/rev/5f03e956749d I'll need to wait for that to get merged to production before backing out the gecko bits.
Assignee | ||
Comment 4•10 years ago
|
||
Seems like I forgot to get around to this. There was a lot of bitrot, so here is a try run to make sure I didn't mess something up: https://tbpl.mozilla.org/?tree=Try&rev=722f5906f0f3
Flags: needinfo?(ahalberstadt)
Assignee | ||
Comment 5•10 years ago
|
||
Comment on attachment 8419675 [details] [diff] [review] backout_hide_subtests Try run looks good. Log sizes are still small.
Attachment #8419675 -
Flags: review?(jmaher)
Flags: needinfo?(ahalberstadt)
Comment 6•10 years ago
|
||
Comment on attachment 8419675 [details] [diff] [review] backout_hide_subtests Review of attachment 8419675 [details] [diff] [review]: ----------------------------------------------------------------- ok, cool stuff ::: testing/mochitest/runtests.py @@ +28,5 @@ > import traceback > import urllib2 > import zipfile > > +from automationutils import environment, getDebuggerInfo, isURL, KeyValueParseError, parseKeyValue, processLeakLog, dumpScreen, ShutdownLeaks, printstatus why are we removing systemMemory? @@ +1361,4 @@ > self.dumpScreenOnTimeout, > self.dumpScreenOnFail, > self.metro_subprocess_id, > self.trackShutdownLeaks, why are we rearranging this?
Attachment #8419675 -
Flags: review?(jmaher) → review+
Assignee | ||
Comment 7•10 years ago
|
||
(In reply to Joel Maher (:jmaher) from comment #6) > Comment on attachment 8419675 [details] [diff] [review] > backout_hide_subtests > > Review of attachment 8419675 [details] [diff] [review]: > ----------------------------------------------------------------- > > ok, cool stuff > > ::: testing/mochitest/runtests.py > @@ +28,5 @@ > > import traceback > > import urllib2 > > import zipfile > > > > +from automationutils import environment, getDebuggerInfo, isURL, KeyValueParseError, parseKeyValue, processLeakLog, dumpScreen, ShutdownLeaks, printstatus > > why are we removing systemMemory? My pyflakes informed me it was imported but unused. Just a drive-by fix up. > @@ +1361,4 @@ > > self.dumpScreenOnTimeout, > > self.dumpScreenOnFail, > > self.metro_subprocess_id, > > self.trackShutdownLeaks, > > why are we rearranging this? The original patch had re-arranged it, so the backout is just re-arranging it back to the way it was.
Comment 8•10 years ago
|
||
ok, land as is!
Assignee | ||
Comment 9•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/6a0b9cf33604
Assignee | ||
Comment 10•10 years ago
|
||
This was merged awhile ago, but must have been missed: https://hg.mozilla.org/mozilla-central/rev/6a0b9cf33604
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•