Closed Bug 974073 Opened 7 years ago Closed 6 years ago

failed mochitests no longer log state

Categories

(Testing :: Mochitest, defect)

defect
Not set
blocker

Tracking

(Not tracked)

RESOLVED FIXED
mozilla30

People

(Reporter: karlt, Assigned: froydnj)

References

Details

Attachments

(1 file)

<karl> are mochitest passes elided from test logs now?
<froydnj> karl: yes
<karl> i would like to know how far a test got before it timed out, but i'm not seeing progress, even for passing tests
<ted> karl: yes
<ted> karl: https://bugzilla.mozilla.org/show_bug.cgi?id=937181
<karl> would changing all the 'ok's to todos provide some progress info? or are there other options?
<karl> dump?
<ted> not sure, froydnj ^^
<karl> froydnj: are successes in a test that fails printed?
<froydnj> ted: adding || true to http://mxr.mozilla.org/mozilla-central/source/testing/mochitest/tests/SimpleTest/SimpleTest.js#330 will get you your log messages back
<karl> froydnj: i need something to run on m-c, not try
<froydnj> karl: dump is probably your best option, I think
<karl> froydnj: this is making it impossible to diagnose failed tests
<karl> froydnj: many failures happen in random tests and it is impractical to dump in all of them
<froydnj> karl: please file a bug about it, then, and make it block bug 937181
Blocks: 966408
No longer blocks: 966322
I think the most reasonable way to do this is to require the test to call:

SimpleTest.requestCompleteLog();

and that will force logging of all TEST-PASSes for the current test.  Does that sound plausible, Joel?
Flags: needinfo?(jmaher)
this looks good and not too insane.
Flags: needinfo?(jmaher)
Probably would have been simpler to just provide the patch in the first
place. :)
Attachment #8381776 - Flags: review?(jmaher)
Assignee: nobody → nfroyd
Attachment #8381776 - Flags: review?(jmaher) → review+
https://hg.mozilla.org/mozilla-central/rev/fea2f41fd6cb
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
You need to log in before you can comment on or make changes to this bug.