969918 - Use decltype to declare pointers for dynamically-loaded functions

Status: RESOLVED FIXED

(Core :: General, defect)

Description

[Masatoshi Kimura [:emk]]

We can remove some hand-written function prototypes. It would also be safer.

Comment 1

[Masatoshi Kimura [:emk]]

Attachment: patch

Try run: https://tbpl.mozilla.org/?tree=Try&rev=de25362ded9c

Comment 2

[Jim Mathies [:jimm]]

Comment on attachment 8372891 [details] [diff] [review]
patch

Looks great, I like how this cleans up the code base. I think though a massive refactoring like this should get an sr from someone like ehsan.

Comment 3

[Jim Mathies [:jimm]]

According to msdn, this is valid in the Visual Studio 2010 tools and up. I wonder if we're going to piss off a bunch of developers who are still stuck on vc9 or less (?).

Comment 4

[Masatoshi Kimura [:emk]]

(In reply to Jim Mathies [:jimm] from comment #3)
> According to msdn, this is valid in the Visual Studio 2010 tools and up. I
> wonder if we're going to piss off a bunch of developers who are still stuck
> on vc9 or less (?).

VC9 support is already dropped (bug 866425). The current tree does not build on VC9 or earlier at all.

Comment 5

[(no longer active)]

Comment on attachment 8372891 [details] [diff] [review]
patch

Review of attachment 8372891 [details] [diff] [review]:
-----------------------------------------------------------------

First of all, this is a great patch!  Thanks a lot for doing this, and please write to dev-platform once this lands to let people know about this technique.  But I'm not sure if this sr? request is a formality or not.  But since I'm not a super-reviewer and have never dared to play the rules loose when it comes to super-reviews, I'm redirecting this to roc.  :-)

Comment 6

[(no longer active)]

Also CCing Jacek since this will affect mingw builds.  (I don't expect that to be a problem for him since gcc has supported decltype for years, but it's nice to let him know in advance!)

Comment 7

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 8372891 [details] [diff] [review]
patch

Review of attachment 8372891 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me!

Comment 8

[Masatoshi Kimura [:emk]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9945bc3b7d36

Comment 9

[Masatoshi Kimura [:emk]]

Posted a message to dev-platform:
https://groups.google.com/d/msg/mozilla.dev.platform/lxJZKAOUw9I/Y9RwX6LP5mwJ

Comment 10

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/9945bc3b7d36