Closed Bug 969918 Opened 6 years ago Closed 6 years ago

Use decltype to declare pointers for dynamically-loaded functions

Categories

(Core :: General, defect)

x86_64
Windows 8.1
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla30

People

(Reporter: emk, Assigned: emk)

Details

Attachments

(1 file)

We can remove some hand-written function prototypes. It would also be safer.
Attached patch patchSplinter Review
Try run: https://tbpl.mozilla.org/?tree=Try&rev=de25362ded9c
Attachment #8372891 - Flags: review?(jmathies)
Comment on attachment 8372891 [details] [diff] [review]
patch

Looks great, I like how this cleans up the code base. I think though a massive refactoring like this should get an sr from someone like ehsan.
Attachment #8372891 - Flags: superreview?(ehsan)
Attachment #8372891 - Flags: review?(jmathies)
Attachment #8372891 - Flags: review+
According to msdn, this is valid in the Visual Studio 2010 tools and up. I wonder if we're going to piss off a bunch of developers who are still stuck on vc9 or less (?).
(In reply to Jim Mathies [:jimm] from comment #3)
> According to msdn, this is valid in the Visual Studio 2010 tools and up. I
> wonder if we're going to piss off a bunch of developers who are still stuck
> on vc9 or less (?).

VC9 support is already dropped (bug 866425). The current tree does not build on VC9 or earlier at all.
Comment on attachment 8372891 [details] [diff] [review]
patch

Review of attachment 8372891 [details] [diff] [review]:
-----------------------------------------------------------------

First of all, this is a great patch!  Thanks a lot for doing this, and please write to dev-platform once this lands to let people know about this technique.  But I'm not sure if this sr? request is a formality or not.  But since I'm not a super-reviewer and have never dared to play the rules loose when it comes to super-reviews, I'm redirecting this to roc.  :-)
Attachment #8372891 - Flags: superreview?(ehsan) → superreview?(roc)
Also CCing Jacek since this will affect mingw builds.  (I don't expect that to be a problem for him since gcc has supported decltype for years, but it's nice to let him know in advance!)
Comment on attachment 8372891 [details] [diff] [review]
patch

Review of attachment 8372891 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me!
Attachment #8372891 - Flags: superreview?(roc) → superreview+
Assignee: nobody → VYV03354
Status: NEW → ASSIGNED
Flags: in-testsuite-
https://hg.mozilla.org/mozilla-central/rev/9945bc3b7d36
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
You need to log in before you can comment on or make changes to this bug.