969922 - Remove fennec_ids.txt usage from Robocop test APK

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Testing, defect)

Description

[Nick Alexander :nalexander [he/him]]

This ticket tracks converting all existing uses of fennec_ids.txt to reference Fennec directly, and to stop loading fennec_ids.txt.

Comment 1

[Nick Alexander :nalexander [he/him]]

Attachment: Pre: Close cursor.

Comment 2

[Nick Alexander :nalexander [he/him]]

Attachment: Part 1: Remove unused cruft from FennecNativeElement.

Comment 3

[Nick Alexander :nalexander [he/him]]

Attachment: Part 2: Replace Driver.findElement(Activity, String) with (Activity, int).

Comment 4

[Nick Alexander :nalexander [he/him]]

Attachment: Part 3: Don't use Solo.getView(String).

Comment 5

[Nick Alexander :nalexander [he/him]]

Attachment: Part 4: Remove final use of fennec_ids.txt.

Comment 6

[Nick Alexander :nalexander [he/him]]

A pleasantly green try build is up at

https://tbpl.mozilla.org/?tree=Try&rev=63f82c0319e0

Comment 7

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Comment on attachment 8372906 [details] [diff] [review]
Pre: Close cursor.

Review of attachment 8372906 [details] [diff] [review]:
-----------------------------------------------------------------

r+ w/ try/finally.

It probably doesn't matter because we'll end the test and kill Fennec when we throw, but better safe than sorry.

::: mobile/android/base/tests/testBrowserProvider.java
@@ +161,5 @@
>          Cursor c = getBookmarkByGuid(MOBILE_FOLDER_GUID);
>          mAsserter.is(c.moveToFirst(), true, "Mobile bookmarks folder is present");
>  
>          mMobileFolderId = c.getLong(c.getColumnIndex(mBookmarksIdCol));
> +        c.close();

`try {} finally { c.close(); }`

Comment 8

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Comment on attachment 8372908 [details] [diff] [review]
Part 2: Replace Driver.findElement(Activity, String) with (Activity, int).

Review of attachment 8372908 [details] [diff] [review]:
-----------------------------------------------------------------

r+ w/ extra R.id usage and comment.

::: mobile/android/base/tests/BaseTest.java
@@ +189,5 @@
>       * Click on the URL bar to focus it and enter editing mode.
>       */
>      protected final void focusUrlBar() {
>          // Click on the browser toolbar to enter editing mode
> +        final View toolbarView = mSolo.getView("browser_toolbar");

Replace "browser_toolbar" with  R.id.browser_toolbar. Similarly below.

::: mobile/android/base/tests/testThumbnails.java
@@ +82,5 @@
>      }
>  
>      private int getTopSiteThumbnailColor(String title) {
> +    	return -1;
> +//        ViewGroup topSites = (ViewGroup) getActivity().findViewById(mTopSitesId);

Add a comment explaining why this is commented out.

Comment 9

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Comment on attachment 8372909 [details] [diff] [review]
Part 3: Don't use Solo.getView(String).

Review of attachment 8372909 [details] [diff] [review]:
-----------------------------------------------------------------

(In reply to Michael Comella (:mcomella) from comment #8)
> Replace "browser_toolbar" with  R.id.browser_toolbar. Similarly below.

Hee hee, nevermind. :P

r+ w/ unused var removed or used.

::: mobile/android/base/tests/BaseTest.java
@@ +560,5 @@
>                  return true;
>              }
>          }, MAX_WAIT_MS);
>          mAsserter.ok(success, "waiting for add tab view", "add tab view available");
> +        final View addTabView = mSolo.getView(R.id.add_tab);

Unused.

Comment 10

[Nick Alexander :nalexander [he/him]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2f4de5bbd44b
https://hg.mozilla.org/integration/mozilla-inbound/rev/84415b7c3f29
https://hg.mozilla.org/integration/mozilla-inbound/rev/d3e11d7ae99d
https://hg.mozilla.org/integration/mozilla-inbound/rev/0219e9ab57a4
https://hg.mozilla.org/integration/mozilla-inbound/rev/a101a9475c10

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/2f4de5bbd44b
https://hg.mozilla.org/mozilla-central/rev/84415b7c3f29
https://hg.mozilla.org/mozilla-central/rev/d3e11d7ae99d
https://hg.mozilla.org/mozilla-central/rev/0219e9ab57a4
https://hg.mozilla.org/mozilla-central/rev/a101a9475c10