969921 - [meta] Remove fennec_ids.txt

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Testing, defect)

Description

[Nick Alexander :nalexander [he/him]]

Robocop tests need to refer to Android View instances.  Such instances are identified by numeric ids.  In code, they are referenced by names; R.java translates names into ids.  Until Bug 916507 landed, the Robocop package could not reference the Fennec package directly.  Instead, a table mapping names to ids was written at build time; this is fennec_ids.txt.

This table is no longer necessary; it complicates the build system (leading to bugs like Bug 961339) and makes it more difficult to run Robocop tests locally (since fennec_ids.txt must be pushed to the device).

This ticket tracks removing fennec_ids.txt entirely.

Comment 1

[Nick Alexander :nalexander [he/him]]

gbrown, you have the most context into the history of Robocop as anybody.  Any reason to not move on this?

Comment 2

[Geoff Brown [:gbrown]]

(In reply to Nick Alexander :nalexander from comment #1)
> gbrown, you have the most context into the history of Robocop as anybody. 
> Any reason to not move on this?

I am not aware of any reason. I would like to see fennec_ids.txt removed -- seems like a good idea.

Comment 3

[Joel Maher ( :jmaher ) (UTC -8)]

I do not see any more bugs blocking this, I assume we can mark this as resolved/fixed?

Comment 4

[Nick Alexander :nalexander [he/him]]

(In reply to Joel Maher (:jmaher) from comment #3)
> I do not see any more bugs blocking this, I assume we can mark this as
> resolved/fixed?

Yes!