The default bug view has changed. See this FAQ.

Remove dependance on fennec_ids.txt from automation

RESOLVED FIXED

Status

Release Engineering
General Automation
RESOLVED FIXED
3 years ago
a year ago

People

(Reporter: nalexander, Assigned: nalexander)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
I have no idea if there are references to fennec_ids.txt on infra (there shouldn't be!) but we should make sure that we don't bust builds when we land Bug 969925.
Please readjust if I've misunderstood, but by this bug you mean to check that buildbot/mozharness/misc automation doesn't have references to the file presently that will cause things to break once bug 969925 lands? Tweaking summary/component :-)
Component: Testing → General Automation
Product: Firefox for Android → Release Engineering
QA Contact: catlee
Summary: Remove fennec_ids.txt from TBPL and the buildbots → Remove dependance on fennec_ids.txt from automation
Version: Trunk → unspecified
(Assignee)

Comment 2

3 years ago
(In reply to Ed Morley [:edmorley UTC+0] from comment #1)
> Please readjust if I've misunderstood, but by this bug you mean to check
> that buildbot/mozharness/misc automation doesn't have references to the file
> presently that will cause things to break once bug 969925 lands? Tweaking
> summary/component :-)

Nope, that's correct.  Our test code (robocop.apk) no longer requires fennec_ids.txt; Bug 969925 tracks removing it from the tree entirely; and this ticket tracks making sure that nothing else depends on it outside of the tree.
(Assignee)

Comment 3

3 years ago
Created attachment 8484364 [details] [diff] [review]
969926.patch

Two points:

1) I don't know how to run a try build with this mozharness change and the corresponding mozilla-central change (Bug 969925).  Would be nice to do that if it's not too hard.

2) I believe we can land this mozharness change before Bug 969925, but not vice versa (since the other ticket removes --robocopIDs from runtestsremote.py).  I don't know how simultaneous these landings could/should be, but it's important to know that we can stage them if we choose.
Assignee: nobody → nalexander
Status: NEW → ASSIGNED
Attachment #8484364 - Flags: review?(jmaher)
(Assignee)

Updated

3 years ago
Blocks: 969925
(Assignee)

Comment 4

3 years ago
I had a long talk with jlund about buildbot and how reconfigs happen.  He suggested I talk to kmoir about getting rid of fennec_ids.txt in buildbot.  It appears that there's only one place [1] that has custom factory steps dealing with fennec_ids.  It's in TalosFactory.  It appears to do more than just download fennec_ids.txt; it also downloads robocop.apk.  jlund *knew* that this code doesn't run for Panda builds, and he suggested that this code might not actually run *anywhere*.  kmoir: can you verify/refute?

If it's not run anywhere (meaning, I assume, that everything is in mozharness), that would be excellent.  We could land a buildbotcustom/buildbot-configs change to excise this fennec_ids stuff without hassle, and move on to cleaning up mozharness and talos.

[1] http://mxr.mozilla.org/build/source/buildbotcustom/process/factory.py#5486
Flags: needinfo?(kmoir)
(Assignee)

Updated

3 years ago
Depends on: 1064002

Comment 5

3 years ago
This is correct. All the panda tests use mozharness and robocop.apk is downloaded within these scripts.
Flags: needinfo?(kmoir)
(Assignee)

Comment 6

3 years ago
(In reply to Kim Moir [:kmoir] from comment #5)
> This is correct. All the panda tests use mozharness and robocop.apk is
> downloaded within these scripts.

Right.  My question is: are there other non-panda tests that use TalosFactory?  Can we delete TalosFactory entirely?
Flags: needinfo?(kmoir)

Comment 7

3 years ago
No, we cannot delete TalosFactory.  It is used by generateTalosBranchObjects to generate the per branch builders for Talos for more than just pandas.
Flags: needinfo?(kmoir)
Comment on attachment 8484364 [details] [diff] [review]
969926.patch

Review of attachment 8484364 [details] [diff] [review]:
-----------------------------------------------------------------

just some nits, I am not sure of the best way to test this, I believe you can land this on mozharness and trigger builds (or retrigger) on the 'ash' branch

::: configs/android/androidarm.py
@@ +288,5 @@
>          },
>          "robocop-1": {
>              "category": "mochitest",
>              "extra_args": ["--total-chunks", "4", "--this-chunk", "1", "--robocop-path=../..",
> +                "--robocop=robocop.ini"],

nit: I would put this on the previous line, same for all items below

::: configs/android/androidx86.py
@@ +117,5 @@
>          },
>          "robocop-1": {
>              "category": "mochitest",
>              "extra_args": ["--total-chunks", "3", "--this-chunk", "1", "--robocop-path=../..",
> +                "--robocop=robocop.ini"],

I would put this on the previous line, same for all items below.
Attachment #8484364 - Flags: review?(jmaher) → review+
afaict this had landed at some point.
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.