970005 - Browser hang, when you clicked left upper red "Gmail"

Status: VERIFIED FIXED

(Core :: Disability Access APIs, defect)

Description

[Alice0775 White]

Build Identifier:
https://hg.mozilla.org/mozilla-central/rev/cafe909f7e07
Mozilla/5.0 (Windows NT 6.3; WOW64; rv:30.0) Gecko/20100101 Firefox/30.0 ID:20140208030207

This hang happens on Windows8.1 only. 
Not reproduce on Wndows7.


Stack on hang : bp-993fe2d6-c1c7-4a50-815a-7c5082140209

Steps To Reproduce:
1. Open https://mail.google.com and sign-in
2. Click red "Gmail" at the left-upper

Actual Results:
Browser freezes

Regression window(m-c)
Good:
http://hg.mozilla.org/mozilla-central/rev/16949049f03d
Mozilla/5.0 (Windows NT 6.3; WOW64; rv:28.0) Gecko/20100101 Firefox/28.0 ID:20131110030205
Bad:
http://hg.mozilla.org/mozilla-central/rev/86afe33114e7
Mozilla/5.0 (Windows NT 6.3; WOW64; rv:28.0) Gecko/20100101 Firefox/28.0 ID:20131110235419
Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=16949049f03d&tochange=86afe33114e7


Regression window(m-i)
Good:
http://hg.mozilla.org/integration/mozilla-inbound/rev/c8d6e8deac02
Mozilla/5.0 (Windows NT 6.3; WOW64; rv:28.0) Gecko/20100101 Firefox/28.0 ID:20131108160815
Bad:
http://hg.mozilla.org/integration/mozilla-inbound/rev/b4a630050f61
Mozilla/5.0 (Windows NT 6.3; WOW64; rv:28.0) Gecko/20100101 Firefox/28.0 ID:20131108162618
Pushlog:
http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=c8d6e8deac02&tochange=b4a630050f61

Regressed by:
b4a630050f61	Alexander Surkov — Bug 933322 - menustart/end events are missing when aria-owns makes a menu hierarchy, r=tbsaunde

Comment 1

[Marco Zehe (:MarcoZ)]

I can confirm this using Nightly 30.0a1 (2013-02-08). Unfortunately it didn't crash, I had to kill it via Task Manager, so I don't have a Crash Reporter ID. Alex, it's the drop down button in the Gmail interface, not the one directly above the Search field. I was running with NVDA.

Comment 2

[rzo1]

I have this bug also.
Note my platform is x86. It is Asus T100.

Firefox beta x86 28

Mozilla/5.0 (Windows NT 6.3; rv:28.0) Gecko/20100101 Firefox/28.0

The browser  also hangs when i tick some mail, click "More" and "Mark as read".

Comment 7

[Trevor Saunders (:tbsaunde)]

So, what I think is happening here is that some element has aria-owns=<element for child accessible> so then at FocusManager.cpp:312 we get the element that owns child, and set parent to point at that.  Then if parent has nothing to do with menus we repeat parent = <element owning <child> which is an endless loop afaict I'm not sure how best to fix this, maybe get the element owning parent that way we always move up (except that might still break with screwy markup that has an element aria-own its parent? I think I'll let Alex decide how to fix this ;)

Comment 8

[David Bolter [:davidb] (NeedInfo me for attention)]

I think it is safe to not support a child aria-owning an ancestor. In any event we need to be cycle proof.

Comment 9

[alexander :surkov (:asurkov)]

Attachment: patch

Comment 10

[alexander :surkov (:asurkov)]

http://hg.mozilla.org/integration/mozilla-inbound/rev/3e9c4bb1ce40

Comment 11

[Marco Zehe (:MarcoZ)]

Comment on attachment 8373524 [details] [diff] [review]
patch

>-    //gA11yEventDumpToConsole = true; // debuging
>+    gA11yEventDumpToConsole = true; // debuging

Alex, did you disable that again before landing?

Comment 12

[Tim Taubert [:ttaubert] (inactive)]

(In reply to Marco Zehe (:MarcoZ) from comment #11)
> >-    //gA11yEventDumpToConsole = true; // debuging
> >+    gA11yEventDumpToConsole = true; // debuging
> 
> Alex, did you disable that again before landing?

Yes, he did.

Comment 13

[Marco Zehe (:MarcoZ)]

(In reply to Tim Taubert [:ttaubert] from comment #12)
> Yes, he did.

Thanks, Tim! :)

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/3e9c4bb1ce40

Comment 15

[alexander :surkov (:asurkov)]

Comment on attachment 8373524 [details] [diff] [review]
patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 933322 
User impact if declined: Firefox hangs on certain sites (gmail is one example)
Testing completed (on m-c, etc.): m-c
Risk to taking this patch (and alternatives if risky): small
String or IDL/UUID changes made by this patch: no

Comment 16

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/59bf63f4e48d
https://hg.mozilla.org/releases/mozilla-beta/rev/708e30a08b94

Comment 17

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g28_v1_3/rev/708e30a08b94

Comment 18

[Paul Silaghi, QA [:pauly]]

I can't reproduce the initial issue on Nightly 30.0a1 (2013-02-08), Win 8.1 32/64 bit.
Alice, can you please confirm it's fixed for you in the latest nightly ?

Comment 19

[Alice0775 White]

I cannot reproduce anymore.
https://hg.mozilla.org/mozilla-central/rev/e5b09585215f
Mozilla/5.0 (Windows NT 6.3; WOW64; rv:30.0) Gecko/20100101 Firefox/30.0 ID:20140305030201

Comment 20

[Paul Silaghi, QA [:pauly]]

Thank you, Alice.