970026 - History Footer button should be fixed at the bottom of the subview

Status: VERIFIED FIXED

(Firefox :: Toolbars and Customization, defect)

Description

[Tim Nguyen :ntim]

Adding flex="1" to #PanelUI-historyItems fixes the issue.

Comment 1

[:Gijs (he/him)]

(In reply to Tim Nguyen [:ntim] from comment #0)
> Adding flex="1" to #PanelUI-historyItems fixes the issue.

Can we start with steps to reproduce, please? How do I get it to not be fixed at the bottom? What does it look like when it isn't? :-)

(also, please make australis bugs you file block 'something', like 'australis-cust' (for customization/panel-related things) or 'australis-tabs-osx/win/linux' (for tabs-related things))

Comment 2

[Tim Nguyen :ntim]

Sorry, here's the info you need :
STR :
- Put the history widget in panel menu
- Click on it
- Make sure you don't have much history items
- You can see that the footer "Show All History" is not fixed at the bottom of the subview

Comment 3

[Tim Nguyen :ntim]

Attachment: Screenshot

It looks even worse when there are no history items.

Comment 4

[:Gijs (he/him)]

Actually, bug 966905 isn't on m-c and I can reproduce on m-c, so I guess that's not it.

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

It is because the mainview is taller than the subview, as you can see in the screenshot.

Comment 6

[:Gijs (he/him)]

(In reply to Tim Nguyen [:ntim] from comment #0)
> Adding flex="1" to #PanelUI-historyItems fixes the issue.

FWIW, given the discussion in bug 947488, I'm somewhat worried that doing that will cause the same issue to start happening with the history subview. Between the two problems, I'd pick this one.

Comment 7

[Tim Nguyen :ntim]

(In reply to :Gijs Kruitbosch from comment #6)
> (In reply to Tim Nguyen [:ntim] from comment #0)
> > Adding flex="1" to #PanelUI-historyItems fixes the issue.
> 
> FWIW, given the discussion in bug 947488, I'm somewhat worried that doing
> that will cause the same issue to start happening with the history subview.
> Between the two problems, I'd pick this one.

The subview footer is now fixed at the bottom in latest nightly.

Comment 8

[:Gijs (he/him)]

Then it was probably fixed by bug 966905. :-)

Comment 9

[Paul Silaghi, QA [:pauly]]

Reproduced in Nightly 2014-02-08.
Verified fixed 30.0a1(2014-02-11), Win 7 x64.

Comment 10

[Jared Wein [:jaws] (please needinfo? me)]

Now fixed on 29 since the patch for bug 966905 has been uplifted to Aurora.