970028 - [Sora][Message]The screen shaked when back to message edit interface.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System::Window Mgmt, defect, P1)

Description

[sync-1]

Firefox OS v1.3
 Mozilla build ID: 20140105004001
 
 DEFECT DESCRIPTION:
 ->SMS screen shake.
 
  REPRODUCING PROCEDURES:
 ->Enter"Messages" to create a message;
 ->Tap"Setting"icon to enter message settings list;
 ->Tap"x" back to the message edit interface;
 
  EXPECTED BEHAVIOUR:
 ->Should display normally.
 
  ASSOCIATE SPECIFICATION:
 
  TEST PLAN REFERENCE:
 
  TOOLS AND PLATFORMS USED:
 
  USER IMPACT:
 
  REPRODUCING RATE:100%
 
  For FT PR, Please list reference mobile's behavior:

Comment 1

[Julien Wajsberg [:julienw]]

Can you please share a video?

thanks!

Comment 2

[田旻]

Attachment: VID_0020.3gp

I upload a video about the shack of transform from sms  to message settings, and then back to sms.

Comment 3

[田旻]

Attachment: VID_0021_1.3gp

Please use this one to check, and ignore last one.

Comment 4

[Julien Wajsberg [:julienw]]

oki, looks like an activity window management issue

Thanks !

Comment 5

[bhavana bajaj [:bajaj]]

Adding qawanted to check if QA is able to reproducible on Mozilla's side ..I tried on a buri device on the build id : 20140213175711 but was unable to hit the issue as described...

Or may be the reporter can try this once again on the latest build to confirm the issue.

Comment 6

[Jason Smith [:jsmith]]

This is too minor to invest QA resources into - clearing the flag.

Comment 7

[Preeti Raghunath(:Preeti)]

Noemi

Can you please prioritize this within TEF? Moz cannot test this in-house, please check if this is an issue.

Comment 8

[Jason Smith [:jsmith]]

(In reply to Preeti Raghunath(:Preeti) from comment #7)
> Noemi
> 
> Can you please prioritize this within TEF? Moz cannot test this in-house,
> please check if this is an issue.

No, that's not the reason why. The priority of the bug is too low, so we should not invest QA resources here. Moving to backlog.

Comment 9

[田旻]

This pr can still be reproduced on version with Mozilla build ID: 20140208004002.

Comment 10

[(inactive after 6/18) Alive Kuo [:alive]]

Attachment: Patch for bubble-tea

The patch is based on bug 961800.

Comment 11

[(inactive after 6/18) Alive Kuo [:alive]]

bubble-tea

https://github.com/mozilla-b2g/gaia/commit/2c1e1f36a74c114ecc7fa812cc75c63f7b5ee48a

Comment 12

[Julien Wajsberg [:julienw]]

Alive, I don't think we need 1.4+ to land the patch on master, if it does not depend on other bubble-tea work.

Let's just land it :)

Comment 13

[(inactive after 6/18) Alive Kuo [:alive]]

Sorry, we need to add some css styles here. I am wrong in my previous response. :/

Comment 14

[(inactive after 6/18) Alive Kuo [:alive]]

Anyway I will make a v1.4 patch!

Comment 15

[[e-mail]]

merged to master https://github.com/gasolin/gaia/commit/870a91032c9d6bd84713618df0e80f0b50962488

Comment 16

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Reverted in https://github.com/mozilla-b2g/gaia/commit/0ef85e9bafc4e3ee1989f1c0e455f82d8313d428 because something in this or one of the six other patches that the b2g bumper bot included in a single push to b2g-inbound broke gaia-ui tests on TBPL:

bumper bot's push's contents: https://hg.mozilla.org/integration/b2g-inbound/rev/0c2938cd910b
The gaia-ui failure: https://tbpl.mozilla.org/php/getParsedLog.php?id=36421229&tree=B2g-Inbound


In the future, can we please not merge seven patches in the course of 5 minutes? It would make tracking down regressions much simpler if they were spaced several minutes apart each.

Comment 17

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Alive, please land this to master with bug 961800 yourself without considering bubble-tea, thanks.

Comment 18

[(inactive after 6/18) Alive Kuo [:alive]]

Got

Comment 19

[(inactive after 6/18) Alive Kuo [:alive]]

Attachment: Patch for master

Cherry-pick bubble-tea and land part of css rules from bug 961800.
Awaiting travis green.

Comment 20

[(inactive after 6/18) Alive Kuo [:alive]]

Green, landing,
https://github.com/mozilla-b2g/gaia/commit/b4e45644fe928b41f1807a9050710645b28ea5cb

Comment 21

[Jason Smith [:jsmith]]

Should we ask for 1.4 approval on this?

Comment 22

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8395536 [details] [review]
Patch for master

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):
[User impact] if declined:
[Testing completed]:
[Risk to taking this patch] (and alternatives if risky):

No risk because it's nearly only css change. Honored new app transition controller gave us the ability to change the opening/closing transition easily as we like.

[String changes made]:

Comment 24

[bhavana bajaj [:bajaj]]

Comment on attachment 8395536 [details] [review]
Patch for master

Alive, request to please help fill all approval request comments inline an any approval request next time. Have also built these guilelines recently which may help : https://wiki.mozilla.org/Release_Management/Uplift_rules#Guidelines_on_approval_comments

For now given the risk of the patch and the attached tests this looks good, hence approving. Requesting QA verification in parallel

Comment 25

[Ryan VanderMeulen [:RyanVM]]

v1.4: https://github.com/mozilla-b2g/gaia/commit/b2cf8148f09526c15ff4ca080560fab484eb2dfa

Comment 26

[bmorgan]

1.4: Smooth transition between screens when backing out from Message Settings while creating message or at Messages home screen.

2.0: Smooth transition between screens when backing out from Message Settings to Messages home screen.  Will not allow access to settings when creating a message.

1.4 Environmental Variables:
Device: Buri 1.4 MOZ
BuildID: 20140527000202
Gaia: 0542778892a294d224e75af4a76be5d42938bc90
Gecko: d583ae109f54
Version: 30.0
Firmware Version: v1.2-device.cfg

2.0 Environmental Variables:
Device: Flame 2.0 MOZ
BuildID: 20140527040202
Gaia: 6a391274cd436f8f0d1fad2db8c6b4805703259c
Gecko: cbe4f69c2e9c
Version: 32.0a1
Firmware Version: 10g-2