services/fxaccounts/FxAccounts.jsm getKeys() breaks when email is verified

RESOLVED WORKSFORME

Status

()

RESOLVED WORKSFORME
5 years ago
11 months ago

People

(Reporter: spenrose, Assigned: spenrose)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Assignee)

Description

5 years ago
STR: create new account using TestFXA app. With app open, verify email. Result: traceback below and "onlogout" event received by app.

*************************
A coding exception was thrown in a Promise resolution callback.

Full message: TypeError: this.whenKeysReadyPromise is null
See https://developer.mozilla.org/Mozilla/JavaScript_code_modules/Promise.jsm/Promise
Full stack: FxAccountsInternal.prototype.getKeys/<@resource://gre/modules/FxAccounts.jsm:338
Handler.prototype.process@resource://gre/modules/Promise.jsm:767
this.PromiseWalker.walkerLoop@resource://gre/modules/Promise.jsm:531

*************************

[13389] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80040111: file /Users/spenrose/repo/hg/mozilla-central/dom/events/nsContentEventHandler.cpp, line 96
Component: Identity → FxA
I think this should be fixed by the patch in Bug 969892 (still pending r from one reviewer)

Can you apply that patch and see if you can still reproduce the problem?

Thanks! j
Flags: needinfo?(spenrose)
(Assignee)

Comment 2

5 years ago
With today's m-c plus this patch plus Gaia main I can still reproduce. If you're not seeing it, let's back-burner this one for a week or two.
Flags: needinfo?(spenrose)
spenrose Thanks for testing.  So apparently it's fixed in the xpcshell tests with the Bug 969892 patch but still manifesting in manual testing.  So there may be more at play here.
Perhaps Bug 971173 has something to do with this
(Assignee)

Comment 5

5 years ago
Assigning to myself and marking worksforme. If we actually see it elsewhere we can reopen.
Assignee: nobody → spenrose
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → WORKSFORME

Updated

11 months ago
Product: Core → Firefox
You need to log in before you can comment on or make changes to this bug.