970111 - services/fxaccounts/FxAccounts.jsm getKeys() breaks when email is verified

Status: RESOLVED WORKSFORME

(Firefox :: Firefox Accounts, defect)

Description

[Sam Penrose]

STR: create new account using TestFXA app. With app open, verify email. Result: traceback below and "onlogout" event received by app.

*************************
A coding exception was thrown in a Promise resolution callback.

Full message: TypeError: this.whenKeysReadyPromise is null
See https://developer.mozilla.org/Mozilla/JavaScript_code_modules/Promise.jsm/Promise
Full stack: FxAccountsInternal.prototype.getKeys/<@resource://gre/modules/FxAccounts.jsm:338
Handler.prototype.process@resource://gre/modules/Promise.jsm:767
this.PromiseWalker.walkerLoop@resource://gre/modules/Promise.jsm:531

*************************

[13389] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80040111: file /Users/spenrose/repo/hg/mozilla-central/dom/events/nsContentEventHandler.cpp, line 96

Comment 1

[Jed Parsons (use needinfo, please) [:jedp, :jparsons]]

I think this should be fixed by the patch in Bug 969892 (still pending r from one reviewer)

Can you apply that patch and see if you can still reproduce the problem?

Thanks! j

Comment 2

[Sam Penrose]

With today's m-c plus this patch plus Gaia main I can still reproduce. If you're not seeing it, let's back-burner this one for a week or two.

Comment 3

[Jed Parsons (use needinfo, please) [:jedp, :jparsons]]

spenrose Thanks for testing.  So apparently it's fixed in the xpcshell tests with the Bug 969892 patch but still manifesting in manual testing.  So there may be more at play here.

Comment 4

[Jed Parsons (use needinfo, please) [:jedp, :jparsons]]

Perhaps Bug 971173 has something to do with this

Comment 5

[Sam Penrose]

Assigning to myself and marking worksforme. If we actually see it elsewhere we can reopen.