970184 - "possible duplicates" shouldn't truncate words at the first non-word character

Status: RESOLVED FIXED

(Bugzilla :: Creating/Changing Bugs, defect)

Description

[:glob ✱]

currently "possible duplicates" does the following:

> # Exclude punctuation from the array.
> @words = map { /(\w+)/; $1 } @words;

this means that all words in the search term are truncated at the first \W character, which can dramatically alter the search.

eg.
entering "gfx-surface-quartz" will search for "gfx"
entering "shouldn't" will search for "shouldn"

i'm not sure what the original purpose of this line is, however given its results i think we should just remove it, and always search on words as entered.

Comment 1

[:glob ✱]

Attachment: 970184_1.patch

during testing i realised the issue it's trying to fix.

if you search for
> "this is" of course, a test, isn't it?
" , and ? need to be removed in order to have sane searches.

so instead of just removing that line, this patch changes it so it only removes leading and trailing punctuation from words.

Comment 3

[:glob ✱]

i'm going to dupe bug 883076 here, since this bug has a patch.

Comment 5

[David Lawrence [:dkl]]

Comment on attachment 8373138 [details] [diff] [review]
970184_1.patch

Review of attachment 8373138 [details] [diff] [review]:
-----------------------------------------------------------------

r=dkl

Comment 6

[:glob ✱]

Committing to: bzr+ssh://[e-mail]/bugzilla/trunk/
modified Bugzilla/Bug.pm
Committed revision 8915.

Committing to: bzr+ssh://[e-mail]/bugzilla/4.4/
modified Bugzilla/Bug.pm
Committed revision 8658.