970241 - B2G NFC: Don't enable/disable NFC when nfc.enabled settings changed

Status: RESOLVED FIXED

(Firefox OS Graveyard :: NFC, defect)

Description

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Right now Gecko will listen nfc.enabled changed event from Settings app, and nfc-hardware-state-change event from System app.

However nfc-hardwre-state-change event is also triggered by nfc.enabled event, so Gecko shouldn't listen to nfc.enabled event anymore.

Comment 1

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Patch

Comment 2

[Dimi Lee [:dimi]]

Comment on attachment 8373255 [details] [diff] [review]
Patch

Review of attachment 8373255 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/system/gonk/Nfc.js
@@ -621,5 @@
> -  handle: function handle(aName, aResult) {
> -    switch(aName) {
> -      case NFC.SETTING_NFC_ENABLED:
> -        debug("'nfc.enabled' is now " + aResult);
> -        this._enabled = aResult;

this._enable doesn't assigned here but it seems receiveMessage still checking it ?

@@ -629,5 @@
> -        // Only if the value changes, set the power config and persist
> -        if (powerLevel !== this.powerLevel) {
> -          debug("New Power Level " + powerLevel);
> -          this.setConfig({powerLevel: powerLevel});
> -          this.powerLevel = powerLevel;

can we remove powerLevel member variable because we are not using it

Comment 3

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

(In reply to Dimi Lee[:dimi][:dlee] from comment #2)
> ::: dom/system/gonk/Nfc.js
> @@ -621,5 @@
> > -  handle: function handle(aName, aResult) {
> > -    switch(aName) {
> > -      case NFC.SETTING_NFC_ENABLED:
> > -        debug("'nfc.enabled' is now " + aResult);
> > -        this._enabled = aResult;
> 
> this._enable doesn't assigned here but it seems receiveMessage still
> checking it ?
> 

Yeah, I think we still need to keep settings related code here.
I will address this.

Thanks

Comment 4

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Patch. v2.

Comment 5

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Patch. v2.1

Just updated subject

Comment 6

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

https://hg.mozilla.org/integration/b2g-inbound/rev/3a6745b683d5

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/3a6745b683d5