Closed Bug 970286 Opened 12 years ago Closed 8 years ago

[VDR][Bluetooth] Apply Buttons and Input areas [BB]

Categories

(Firefox OS Graveyard :: Gaia::Bluetooth, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Bluetooth
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED WONTFIX

People

(Reporter: pivanov, Assigned: pivanov)

References

Details

(Whiteboard: ux-tracking, visual design, visual-tracking, bokken )

Attachments

(2 files)

patch for Gaia/master
46 bytes, text/x-github-pull-request
iliu
: review+
arnau
: feedback+
Details | Review
2014-04-07-05-13-47.png
62.48 KB, image/png
Details
No description provided.
Attachment #8400106 - Flags: feedback?(arnau)
Attachment #8400106 - Flags: review?(echou)
Comment on attachment 8400106 [details] [review] patch for Gaia/master LGTM :)
Attachment #8400106 - Flags: feedback?(arnau) → feedback+
Hi Pavel, (In reply to Pavel Ivanov [:ivanovpavel] from comment #1) > Created attachment 8400106 [details] [review] > patch for Gaia/master I mainly work on Gecko Bluetooth implementation, not Gaia. Ian Liu is the owner of Gaia::BluetoothFileTransfer. He might be the one you should look for. :)
Attachment #8400106 - Flags: review?(echou)
ni reporter in order to not miss comment 3.
Flags: needinfo?(pivanov)
Oh OK :) thanks :)
Flags: needinfo?(pivanov)
Attachment #8400106 - Flags: review?(iliu)
Comment on attachment 8400106 [details] [review] patch for Gaia/master Hi Pavel, Thanks for your help on BB updates. For the review, in my manual test with your patch, the width of search button is not correct. Please see my attached image. The sheet change have an influence on Bluetooth file transfer layout. Please check it again after new magic BB applied.
Attachment #8400106 - Flags: review?(iliu)
Attached image 2014-04-07-05-13-47.png —
The width of search button is not correct.
Comment on attachment 8400106 [details] [review] patch for Gaia/master Hey Ian, thanks for the help ... I think now the "search for device" button look good and I also check the lists section and I think that it look ok too :) hope everything is ok now
Attachment #8400106 - Flags: review?(iliu)
Comment on attachment 8400106 [details] [review] patch for Gaia/master Looks good for me. Thanks for your help. r+ :)
Attachment #8400106 - Flags: review?(iliu) → review+
Firefox OS is not being worked on
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: