Closed Bug 970323 Opened 10 years ago Closed 10 years ago

Cost control in the notification panel broken after disabling flight mode

Categories

(Firefox OS Graveyard :: Gaia::Cost Control, defect)

defect
Not set
normal

Tracking

(blocking-b2g:1.3+, b2g-v1.3 fixed, b2g-v1.3T fixed, b2g-v1.4 fixed)

VERIFIED FIXED
1.4 S1 (14feb)
blocking-b2g 1.3+
Tracking Status
b2g-v1.3 --- fixed
b2g-v1.3T --- fixed
b2g-v1.4 --- fixed

People

(Reporter: flaburgan, Assigned: mai)

References

Details

(Keywords: regression)

Attachments

(1 file)

46 bytes, text/x-github-pull-request
salva
: review+
Details | Review
User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:26.0) Gecko/20100101 Firefox/26.0 (Beta/Release)
Build ID: 20131206145143

Steps to reproduce:

Enable then disable flight mode
Open the notification panel from the header


Actual results:

At the bottom of the notification panel, Cost Control indicates "No sim card available"


Expected results:

Cost Control should display the quantity of data already used.
This is a regression presents in the last 1.3 build by Geeksphone for Keon.
Everything was fine with the 1.2 build.
blocking-b2g: --- → 1.3?
Adding qawanted to confirm this bug on one of the production devices. :jsmith mentioned he'd cover this in today's smoke test testing hence leaving a NI on him here.
Flags: needinfo?(jsmith)
I'll leave qawanted for someone to check if this happens on the latest 1.3 buri device.
Flags: needinfo?(jsmith)
Keywords: qawanted
This issue does reproduce on the 02/10/14 1.3 build on a Buri.

Device: Buri v1.3 MOZ RIL
BuildID: 20140210004002
Gaia: 5c8416fb1ea4a27f172ee6386ab3c19135448506
Gecko: 9c9382f433c0
Version: 28.0
Firmware Version: V1.2-device.cfg
Keywords: qawanted
Can we verify this doesn't reproduce on 1.1?
Status: UNCONFIRMED → NEW
Ever confirmed: true
Keywords: qawanted, regression
(In reply to Jason Smith [:jsmith] from comment #5)
> Can we verify this doesn't reproduce on 1.1?

Actually the reporter already figured this out, so let's get a window on this.
The patch for the bug 960500 fixes this bug.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → DUPLICATE
blocking-b2g: 1.3? → ---
(In reply to marina rodríguez [:mai] from comment #7)
> The patch for the bug 960500 fixes this bug.
> 
> *** This bug has been marked as a duplicate of bug 960500 ***

This needs to be fixed separately of bug 960500 to resolve the regression.
Status: RESOLVED → REOPENED
blocking-b2g: --- → 1.3?
Resolution: DUPLICATE → ---
This regression is produced because the widget cannot detect the sim when the airplane mode is disabled. To do this, we need to add a listener to detect when the mobile enables or disables the airplane mode. This listener is provided by the patch for the bug 960500. 

I don't know if make sense implemented the solution twice, because the listener is needed for resolving both bugs.

WDYT?
Flags: needinfo?(jsmith)
(In reply to marina rodríguez [:mai] from comment #9)
> This regression is produced because the widget cannot detect the sim when
> the airplane mode is disabled. To do this, we need to add a listener to
> detect when the mobile enables or disables the airplane mode. This listener
> is provided by the patch for the bug 960500. 
> 
> I don't know if make sense implemented the solution twice, because the
> listener is needed for resolving both bugs.
> 
> WDYT?

The problem with relying purely on the other bug's solution is that it's introducing strings for the error message as well, which is irrelevant to the fix here. We also can't take non-critical string changes at this point for 1.3, so we need a 1.3-specific patch here that focuses only on what regressed without introducing strings.
Flags: needinfo?(jsmith)
This issue started reproducing on the 01/31/14 1.3 build. 

The following regression window was found using tinderbox builds...

- Works -
Device: Buri ENG v1.3 MOZ RIL
BuildID: 20140131002126
Gaia: 0ddcd8da5bfe1b48c73502ef29220e92f2db6b73
Gecko: 32e45047b663
Version: 28.0a2
Firmware Version: V1.2-device.cfg

- Broken -
Device: Buri ENG v1.3 MOZ RIL
BuildID: 20140131032626
Gaia: 190b3e90ec8b93bd44155bd7dbac29143d902f58
Gecko: 39082f7d147e
Version: 28.0a2
Firmware Version: V1.2-device.cfg
Assignee: nobody → mri
Attached file patch v1.0
Salva, please, could you review the code?
Regards
Attachment #8374672 - Flags: review?(salva)
Comment on attachment 8374672 [details] [review]
patch v1.0

Ask for my review again once you solve the race condition. Thank you!
Attachment #8374672 - Flags: review?(salva)
triage: 1.3+ regression
blocking-b2g: 1.3? → 1.3+
Comment on attachment 8374672 [details] [review]
patch v1.0

Salva, I thought that the race condition is solved. Could you check the code?
Regards
Attachment #8374672 - Flags: review?(salva)
Comment on attachment 8374672 [details] [review]
patch v1.0

I think you are have unnecessary changes in the patch. Can you see if I'm ok? If so, remove them. Anyway I agree on the airplane detection part. Thank you!
Attachment #8374672 - Flags: review?(salva) → review+
Target Milestone: --- → 1.4 S1 (14feb)
Master: 4ed537972ee7c28753c0c7f7ef10a3651a349426
Status: REOPENED → RESOLVED
Closed: 10 years ago10 years ago
Resolution: --- → FIXED
Comment on attachment 8374672 [details] [review]
patch v1.0

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

The widget is not working when airplane mode is disabled.

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): 
[User impact] if declined: The widget on the notification tray does not work when airplaneMode is disabled.
[Testing completed]: Yes
[Risk to taking this patch] (and alternatives if risky): Low, only added a listener to detects when AirplaneMode is enabled/disabled
[String changes made]:
Attachment #8374672 - Flags: approval-gaia-v1.3?(fabrice)
Keywords: verifyme
Attachment #8374672 - Flags: approval-gaia-v1.3?(fabrice) → approval-gaia-v1.3+
v1.3: ba329eaf2c3afefc2fdd8ba93fa7f878f9720517
Thanks for the great work guys!
Verified fixed in 2014/02/19 master build on Buri.

Environmental Variables:
Device: Buri v1.4 Moz RIL
BuildID: 20140219040204
Gaia: ac06cfbd2baf6494ffbb668cc599e3892cd5e17b
Gecko: bf0e76f2a7d4
Version: 30.0a1
Firmware Version: v1.2-device.cfg
Status: RESOLVED → VERIFIED
Keywords: verifyme
QA Contact: bzumwalt
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: