Closed Bug 970337 Opened 6 years ago Closed 6 years ago

switch Help -> Submit feedback to use a product url

Categories

(Firefox :: Menus, defect)

defect
Not set

Tracking

()

VERIFIED FIXED
Firefox 30

People

(Reporter: willkg, Assigned: mythmon)

References

Details

Attachments

(1 file)

We recently implemented product urls in Input (https://input.mozilla.org/). It behooves us all greatly if Firefox Desktop switched to using a product url in the menu. Right now we're inferring all this from the User-Agent and HTTP headers which is mostly accurate, but has some issues.

The product url to switch it to would be this:

https://input.mozilla.org/%LOCALE%/feedback/%PRODUCT%/%VERSION%/
This probably involves the following:

1. Creating a pref like we have for SUMO:

http://dxr.mozilla.org/mozilla-central/source/browser/app/profile/firefox.js#954


2. Changing openFeedbackPage to use that pref url rather than the hard-coded one:

http://dxr.mozilla.org/mozilla-central/source/browser/base/content/utilityOverlay.js#560

I naively suspect you could reuse the SUMO code here:

http://dxr.mozilla.org/mozilla-central/source/browser/base/content/utilityOverlay.js#653
Summary: switch Help -> Feedback url to use a product url → switch Help -> Submit feedback to use a product url
(In reply to Will Kahn-Greene [:willkg] from comment #1)
> This probably involves the following:
> 
> 1. Creating a pref like we have for SUMO:
> 
> http://dxr.mozilla.org/mozilla-central/source/browser/app/profile/firefox.
> js#954
> 
> 
> 2. Changing openFeedbackPage to use that pref url rather than the hard-coded
> one:
> 
> http://dxr.mozilla.org/mozilla-central/source/browser/base/content/
> utilityOverlay.js#560
> 
> I naively suspect you could reuse the SUMO code here:
> 
> http://dxr.mozilla.org/mozilla-central/source/browser/base/content/
> utilityOverlay.js#653

Sounds about right to me. Want to work this out into a patch? :-)
Component: General → Menus
I talked with :willkg a bit on irc. I'm going to work on this. Sounds like a good bug to get my feet wet with hacking on Firefox.
Assignee: nobody → mcooper
Awesome. Thanks mythmon!
This is the first time I've touch mozilla-central, so let me know if I screwed anything up.
Attachment #8375874 - Flags: review?(mak77)
Comment on attachment 8375874 [details] [diff] [review]
variable-feedback-url.patch

Review of attachment 8375874 [details] [diff] [review]:
-----------------------------------------------------------------

It looks good to me, thanks
Attachment #8375874 - Flags: review?(mak77) → review+
Comment on attachment 8375874 [details] [diff] [review]
variable-feedback-url.patch

I don't have commit access. Can someone please check this in for me?
Attachment #8375874 - Flags: checkin?
Comment on attachment 8375874 [details] [diff] [review]
variable-feedback-url.patch

https://hg.mozilla.org/integration/fx-team/rev/b237a3162787

In the future, please just use the checkin-needed bug keyword. :)
Attachment #8375874 - Flags: checkin? → checkin+
Thanks Ryan, and thanks for letting my know the right way to do this next time. At this point, is there anything else I need to do? I'm not sure what the fx-team branch is. Is that just a precursor to actually being merged into mozilla-central?

Should this bug be marked as fixed now, or is there something else that needs to happen first?
https://hg.mozilla.org/mozilla-central/rev/b237a3162787
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 30
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.