970377 - [Messages][Drafts] Drafts are kept forever

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[:gerard-majax]

Drafts are always kept in the message thread when sending new SMS. Reproducing with gecko/gaia master (8937359/0d080de).

STR:
 0. Go in a SMS thread
 1. Start a message, leave the thread. This should create a draft
 2. Close the application, restart it
 3. Draft is still in the thread
 4. Open again the thread
 5. Draft content is added in the input field
 6. Erase the input, send a SMS and close the application
 7. Start again the application

Expected:
 There is no more draft in the thread

Actual:
 Draft from step (1) is still in the thrad

Comment 2

[Joe Cheng [:jcheng] (please needinfo)]

triage: major usability issue 1.4+

Comment 3

[Rick Waldron [:rwaldron]]

Attachment: https://github.com/mozilla-b2g/gaia/pull/16529

https://travis-ci.org/mozilla-b2g/gaia/builds/19355235

Comment 4

[Julien Wajsberg [:julienw]]

Comment on attachment 8379875 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/16529

r=me with one comment

thanks !

please land on a green travis

Comment 5

[Rick Waldron [:rwaldron]]

(In reply to Julien Wajsberg [:julienw] from comment #4)
> Comment on attachment 8379875 [details] [review]
> https://github.com/mozilla-b2g/gaia/pull/16529
> 
> r=me with one comment
> 
> thanks !
> 
> please land on a green travis

Will do!

Here is the new travis link: https://travis-ci.org/mozilla-b2g/gaia/builds/19356752

Comment 6

[Rick Waldron [:rwaldron]]

Issues with a leaky sinon spy needed to be addressed, new travis link: https://travis-ci.org/mozilla-b2g/gaia/builds/19361751

Comment 7

[Rick Waldron [:rwaldron]]

https://github.com/mozilla-b2g/gaia/commit/7742135d6f1204f28145d8bc716f52fa67c70344