Closed Bug 970540 Opened 10 years ago Closed 10 years ago

`onLoad` not firing for Fennec Tabs

Categories

(Add-on SDK Graveyard :: General, defect)

Product:
Add-on SDK Graveyard
Component:
General
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: jsantell, Assigned: jsantell)

References

Details

Attachments

(1 file)

GH PR 1399
46 bytes, text/x-github-pull-request
evold
: review+
Details | Review 
No tests for this, and breaking the ContentScriptWhen page-mod tests that use sdk/tabs events on fennec
Blocks: 854990
Attached file GH PR 1399 — 
Looks like onLoad was never implemented on Fennec
Attachment #8373753 - Flags: review?(evold)
Comment on attachment 8373753 [details] [review]
GH PR 1399

I'm going to have Irakli review this since he is detraitifying tabs.
Attachment #8373753 - Flags: review?(evold) → review?(rFobic)
Attachment #8373753 - Flags: review?(rFobic) → review+
Commits pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/31c23dc3117308b84ce8c11f53cd00917411b601
Bug 970540 Implement onLoad for Fennec tabs, fixes page-mod tests

https://github.com/mozilla/addon-sdk/commit/616ede7a8846e68413af6801773a4e0dc02a89ca
Merge pull request #1399 from jsantell/970540-fennec-tabs-onload

Fix Bug 970540 Implement onLoad for Fennec tabs, fixes page-mod tests, r=@erikvold
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: