Closed Bug 854990 Opened 11 years ago Closed 10 years ago

Remove traits from page-mod implementation

Categories

(Add-on SDK Graveyard :: General, defect, P1)

Product:
Add-on SDK Graveyard
Component:
General
Platform:
x86
macOS
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: irakli, Assigned: jsantell)

References

Details

(Whiteboard: [good first bug])

Attachments

(1 file)

GH PR 1350
46 bytes, text/x-github-pull-request
zer0
: review+
Details | Review 
      No description provided.
Blocks: sdk/page-mod
Whiteboard: [good first bug]
Assignee: nobody → jsantell
Attached file GH PR 1350 — 

        Attachment #8360744 -
        Flags: review?(zer0)

    
    

    
  
Comment on attachment 8360744 [details] [review]
GH PR 1350

Looks good, r+ with the comments addressed and if all tests are passing (and if it was tested on fennec too).

        Attachment #8360744 -
        Flags: review?(zer0) → review+
Depends on: 970540

    
    

    
  
Commits pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/45c66005826ab16e0b5fc6086d796b3d90cdd6cb
Bug 854990: Detraitify Page-Mod

https://github.com/mozilla/addon-sdk/commit/58283ea264c9528c452b273d9abb7d0c82916d30
Merge pull request #1350 from jsantell/854990-detraitify-pagemod

Fix Bug 854990: Detraitify Page-Mod, r=@zer0

    
  
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: