Closed
Bug 854990
Opened 12 years ago
Closed 11 years ago
Remove traits from page-mod implementation
Categories
(Add-on SDK Graveyard :: General, defect, P1)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: irakli, Assigned: jsantell)
References
Details
(Whiteboard: [good first bug])
Attachments
(1 file)
No description provided.
|
Reporter | |
Updated•12 years ago
|
Blocks: sdk-kill-traits
Priority: -- → P1
|
||
Updated•11 years ago
|
Blocks: sdk/page-mod
Whiteboard: [good first bug]
|
Assignee | |
Updated•11 years ago
|
Assignee: nobody → jsantell
|
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #8360744 -
Flags: review?(zer0)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 8360744 [details] [review]
GH PR 1350
Looks good, r+ with the comments addressed and if all tests are passing (and if it was tested on fennec too).
Attachment #8360744 -
Flags: review?(zer0) → review+
|
||
Comment 3•11 years ago
|
||
Commits pushed to master at https://github.com/mozilla/addon-sdk
https://github.com/mozilla/addon-sdk/commit/45c66005826ab16e0b5fc6086d796b3d90cdd6cb
Bug 854990: Detraitify Page-Mod
https://github.com/mozilla/addon-sdk/commit/58283ea264c9528c452b273d9abb7d0c82916d30
Merge pull request #1350 from jsantell/854990-detraitify-pagemod
Fix Bug 854990: Detraitify Page-Mod, r=@zer0
|
|
||
Updated•11 years ago
|
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•